Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29856555: Fixes #22 - Upload the "Mobile Ads Study" to the acceptableads.com website (Closed)

Created:
Aug. 15, 2018, 6:18 a.m. by ire
Modified:
Aug. 18, 2018, 3:49 a.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/web.acceptableads.com
Visibility:
Public.

Description

Fixes #22 - Upload the "Mobile Ads Study" to the acceptableads.com website

Patch Set 1 #

Patch Set 2 : Optimise pdf #

Patch Set 3 : Rename pdf file #

Patch Set 4 : Use smaller pdf file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pages/committee/documents.md View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
ire
Aug. 15, 2018, 6:18 a.m. (2018-08-15 06:18:53 UTC) #1
ire
The PDF is still too large for rietveld after optimisation :/ The file size is ...
Aug. 15, 2018, 6:23 a.m. (2018-08-15 06:23:08 UTC) #2
juliandoucette
LGTM + NIT NIT: I'd spell out "acceptable-ads-committee" for SEO and to be consistent with ...
Aug. 16, 2018, 1:04 p.m. (2018-08-16 13:04:45 UTC) #3
ire
On 2018/08/16 13:04:45, juliandoucette wrote: > LGTM + NIT > > NIT: I'd spell out ...
Aug. 16, 2018, 4:30 p.m. (2018-08-16 16:30:35 UTC) #4
ire
Aug. 18, 2018, 3:46 a.m. (2018-08-18 03:46:25 UTC) #5
On 2018/08/16 16:30:35, ire wrote:
> On 2018/08/16 13:04:45, juliandoucette wrote:
> > LGTM + NIT 
> > 
> > NIT: I'd spell out "acceptable-ads-committee" for SEO and to be consistent
> with
> > other file names.
> 
> Done.
> 
> > I'd also ask them if they can make the PDF smaller if you haven't already.
> 
> Just asked them, I'll push this when I get a response from them.

I managed to get a smaller file size from them (1.7 MB), will push this now.

Powered by Google App Engine
This is Rietveld