Issue 29856567: Issue 6826 - Use contentScripts API for snippets if available

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29856567: Issue 6826 - Use contentScripts API for snippets if available

Created:
Aug. 15, 2018, 2:30 p.m. by Manish Jethani

Modified:
Aug. 15, 2018, 3:19 p.m.

Reviewers:
Sebastian Noack

CC:
kzar

Base URL:
https://hg.adblockplus.org/adblockpluschrome/

Visibility:
Public.

Description

Depends on https://codereview.adblockplus.org/29856564/

Patch Set 1 #

Created: Aug. 15, 2018, 2:30 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -1 line)			Patch
	M	lib/contentFiltering.js	View		3 chunks	+54 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Manish Jethani

Aug. 15, 2018, 3:19 p.m. (2018-08-15 15:19:00 UTC) #3

On 2018/08/15 14:32:26, Manish Jethani wrote:
> Patch Set 1
> 
> Try this on Firefox 59+.

You can try with the following document:

  <!DOCTYPE html>
  <script>
    console.log("Hello from document");
  </script>

And the following filter:

  127.0.0.1#$#log 'Hello from snippet'; trace 'Hello from snippet again'

It prints:

  Hello from snippet
  Hello from document
  Hello from snippet again

The last one is after the document's inline script because it's injected as a
<script> element into the DOM.

Expand All Messages | Collapse All Messages