Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29856570: Fixes #120 - Force Portugese Subtitles for homepage video on PT_BR (Closed)

Created:
Aug. 15, 2018, 2:50 p.m. by ire
Modified:
Aug. 18, 2018, 3:28 a.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Fixes #120 - Force Portugese Subtitles for homepage video on PT_BR

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M includes/hero-download.html View 1 chunk +1 line, -1 line 0 comments Download
A includes/hero-download-video-url.tmpl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
ire
Aug. 15, 2018, 2:50 p.m. (2018-08-15 14:50:32 UTC) #1
juliandoucette
This seems to work for now. But what happens if we add more subtitle languages?
Aug. 15, 2018, 9:44 p.m. (2018-08-15 21:44:30 UTC) #2
ire
On 2018/08/15 21:44:30, juliandoucette wrote: > This seems to work for now. But what happens ...
Aug. 16, 2018, 4:26 p.m. (2018-08-16 16:26:37 UTC) #3
juliandoucette
Aug. 16, 2018, 7:51 p.m. (2018-08-16 19:51:13 UTC) #4
Ack. LGTM.

(We'll have this review for reference later.)

Powered by Google App Engine
This is Rietveld