Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29861582: Issue 6879 - Update adblockplusui dependency to 476bd7fa39b6 (Closed)

Created:
Aug. 22, 2018, 7:05 p.m. by saroyanm
Modified:
Sept. 7, 2018, 2:54 p.m.
Reviewers:
Sebastian Noack, kzar
CC:
wspee
Visibility:
Public.

Description

Issue 6879 - Update adblockplusui dependency to 476bd7fa39b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M dependencies View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
saroyanm
This is ready to be reviewed, thanks again.
Aug. 22, 2018, 7:06 p.m. (2018-08-22 19:06:49 UTC) #1
Sebastian Noack
LGTM. Please land in master.
Aug. 22, 2018, 7:13 p.m. (2018-08-22 19:13:21 UTC) #2
saroyanm
On 2018/08/22 19:13:21, Sebastian Noack wrote: > LGTM. Please land in master. Thanks Sebastian, I ...
Aug. 22, 2018, 7:19 p.m. (2018-08-22 19:19:36 UTC) #3
Sebastian Noack
On 2018/08/22 19:19:36, saroyanm wrote: > On 2018/08/22 19:13:21, Sebastian Noack wrote: > > LGTM. ...
Aug. 22, 2018, 7:28 p.m. (2018-08-22 19:28:58 UTC) #4
saroyanm
Aug. 22, 2018, 7:41 p.m. (2018-08-22 19:41:22 UTC) #5
On 2018/08/22 19:28:58, Sebastian Noack wrote:
> On 2018/08/22 19:19:36, saroyanm wrote:
> > On 2018/08/22 19:13:21, Sebastian Noack wrote:
> > > LGTM. Please land in master.
> > 
> > Thanks Sebastian, I will, should I wait for the ticket to be marked as ready
> > before pushing -> https://issues.adblockplus.org/ticket/6879 ?
> 
> No, go ahead. I'm afk (online with my phone) and therefore cannot log into
Trac
> at the moment.

Noted, Done.

Powered by Google App Engine
This is Rietveld