Issue 6871 - Reject filters with blank CSPs

Issue 6871 - Remove support for accepting empty CSP filters with blank values

[Jon Sonesen, 2018-08-22 19:50:11]

Added both of you to review since Manish is out till Monday and I wasn't sure if
kzar would have the time this week.

[Manish Jethani, 2018-08-23 14:41:03]

We should add a test for this. You can search for "filter_invalid_csp" in
test/filterClasses.js

[Manish Jethani, 2018-08-23 14:51:31]

Nit: You could rewrite the commit message as "Issue 6871 - Reject filters with
blank CSPs" but this is just a personal preference.

[Jon Sonesen, 2018-08-23 16:43:51]

Will do, also I prefer your commit message so will update that as well

[Jon Sonesen, 2018-08-23 16:43:54]

Will do, also I prefer your commit message so will update that as well

[Manish Jethani, 2018-08-24 08:55:03]

One more comment, otherwise LGTM

https://codereview.adblockplus.org/29861585/diff/29862572/test/filterClasses.js
File test/filterClasses.js (right):

https://codereview.adblockplus.org/29861585/diff/29862572/test/filterClasses....
test/filterClasses.js:342: compareFilter(test, "bla$csp=", ["type=invalid",
"text=bla$csp=", "reason=filter_invalid_csp"]);
Let's also add a test for "bla$csp" (without the `=`).

[Jon Sonesen, 2018-08-24 20:12:49]

https://codereview.adblockplus.org/29861585/diff/29862572/test/filterClasses.js
File test/filterClasses.js (right):

https://codereview.adblockplus.org/29861585/diff/29862572/test/filterClasses....
test/filterClasses.js:342: compareFilter(test, "bla$csp=", ["type=invalid",
"text=bla$csp=", "reason=filter_invalid_csp"]);
On 2018/08/24 08:55:02, Manish Jethani wrote:
> Let's also add a test for "bla$csp" (without the `=`).

Done.

[Manish Jethani, 2018-08-25 07:34:25]

LGTM

[Manish Jethani, 2018-08-26 15:57:50]

On 2018/08/25 07:34:25, Manish Jethani wrote:
> LGTM

https://hg.adblockplus.org/adblockpluscore/rev/9ebb3381fcde

You can close this now.