Issue 6651 - Pt1: Qunit tests through gitlab CI (PENDING)

.gitlab-ci.yml

Index: .gitlab-ci.yml
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
new file mode 100644
index 0000000000000000000000000000000000000000..f82d03d887286f2b69616e82e37932d4af1cedc6
--- /dev/null
+++ b/.gitlab-ci.yml
@@ -0,0 +1,56 @@
+# This file is part of Adblock Plus <https://adblockplus.org/>,
+# Copyright (C) 2006-present eyeo GmbH
+#
+# Adblock Plus is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 3 as
+# published by the Free Software Foundation.
+#
+# Adblock Plus is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+
+stages:
+  - install
+  - test_ext
+
+.gecko_branch: &gecko_branch

[Sebastian Noack, 2018/08/23 23:35:53]

What does that do?

[tlucas, 2018/08/24 10:27:58]

Removed now, but FWIW:

this template (used as a variable) was meant to keep the .yml dry (i.e. specify
target branches for builds only once)

+  only:
+    - branches
+
+prepare-dependencies:
+  stage: install
+  script:
+    - mkdir -p .git/info && touch .git/info/exclude

[Sebastian Noack, 2018/08/23 23:35:53]

Perhaps we should rather adapt ensure_dependencies.py so that it doesn't attempt
to setup the excludes if running from outside a repository. This would not only
make this line redundant but also allows to run ensure_dependecies.py in other
contexts (e.g. after unpacking the code from an archive file).

[tlucas, 2018/08/24 10:27:58]

While you're right about the perks, i'd rather not initiate a change to the
buildtools and a subsequent dependency update, when the only additional perk is
nothing we desperately need / is not part of the prio directly.

(FWIW the folder in question actually is a repository, it's just that .git/info
is not created by the runners "git clone"/"git fetch" configuration)

+    - pip install --user -r build_requirements.txt

[Sebastian Noack, 2018/08/23 23:45:06]

If the only purpose of the requirements file is to refer to it here and as long
as it only contains a couple packages, I might rather inline the packages here.

[tlucas, 2018/08/24 10:27:58]

Done.

+    - python ensure_dependencies.py
+    - npm install
+  cache:
+    key: cache_$CI_COMMIT_SHA

[Sebastian Noack, 2018/08/23 23:35:53]

Is there any point in caching if the cache is invalidated with every new commit
anyway?

[tlucas, 2018/08/24 10:27:58]

Removed now, but FWIW:

The cache is shared across all the jobs inside a pipline with this key, meaning
"ensure_dependencies.py" is only run once (best case, no guarantee) for the
testing, building and deployment stages. Otherwise each job would freshly clone
the repository and would have to execute the full cloning process from
ensure_dependencies.py again.

+    paths:
+      - ./
+    policy: push
+
+# reusable template for browser-test jobs
+.browser_test_t: &browser_test
+  stage: test_ext
+  script:
+    - npm test -- $TARGET
+  cache:
+    key: cache_$CI_COMMIT_SHA
+    paths:
+      - ./
+    policy: pull
+  environment:
+    name: devbuilds
+
+# Invoke browser tests
+
+qunit:gecko:
+  variables:
+    TARGET: gecko

[Sebastian Noack, 2018/08/23 23:35:53]

Where is this variable picked up?

[tlucas, 2018/08/24 10:27:58]

Line 41, However, it's removed now.

+  <<: *browser_test
+  <<: *gecko_branch