Issue 6651 - Pt1: Qunit tests through gitlab CI (PENDING)

.gitlab-ci.yml

Index: .gitlab-ci.yml
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
new file mode 100644
index 0000000000000000000000000000000000000000..4109a810e68940c367cffb763069bc325ebf23d2
--- /dev/null
+++ b/.gitlab-ci.yml
@@ -0,0 +1,25 @@
+# This file is part of Adblock Plus <https://adblockplus.org/>,
+# Copyright (C) 2006-present eyeo GmbH
+#
+# Adblock Plus is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 3 as
+# published by the Free Software Foundation.
+#
+# Adblock Plus is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+
+stages:
+  - test_ext

[sergei, 2018/08/24 14:20:07]

I'm also not sure that it's already time to introduce stages, but it's fine for
me.

+
+qunit:gecko:
+  stage: test_ext
+  script:
+    - mkdir -p .git/info
+    - pip install --user Jinja2 cryptography

[sergei, 2018/08/24 14:20:07]

I would also think about adding of `pip install -U pip`. According to my
experience, images of CI sometimes are not updated so often and as the result
one gets complains about obsolete pip.

+    - npm install

[sergei, 2018/08/24 13:19:23]

what about moving all these steps but `npm test` into before_script?

[tlucas, 2018/08/24 13:35:22]

By the time we introduce more stages (building / deploying) to the CI/CD, those
would be run for *every* job and severely slow down execution time. The solution
for that is caching, so those steps will be removed from before_script later on
anyway.

[sergei, 2018/08/24 14:20:08]

I personally don't find caching of such things as a good idea, but it's up to
any project team. Nevertheless, I proposed to create before_script for this
particular job mainly for the sake of order and self-description. All these
steps of preparing the environment should be separated from the actual actions,
in this case from running the tests. I don't insist on it, it's just a good
practice which is used in other projects, despite the everything could be in
`script`.

Do I correctly understand that a global before_script is executed for each job,
thus several times? If so, then I think that one could add a stage "prepare" and
just move the content of the current `before_script` to `script` of "prepare".

+    - npm test