Issue 6870 - Remove support for legacy :-abp-properties() syntax

lib/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 104 matching lines @@
  * basic parsing and calls the right constructor then.
  *
  * @param {string} text   as in Filter()
  * @return {Filter}
  */
 Filter.fromText = function(text)
 {
   let filter = Filter.knownFilters.get(text);
   if (filter)
     return filter;
+  if (/\[-abp-properties=(["'])([^"']+)\1\]/i.test(text))

[Manish Jethani, 2018/08/25 07:31:10]

This would be nice to do, but we simply cannot afford this for performance
reasons. In fact the very reason for setting this issue to P2 is because it's so
important for the performance of this function (which really matters on mobile
or so they tell me).

[Jon Sonesen, 2018/08/27 21:32:21]

Done.

+    return new InvalidFilter(text, "filter_unknown_option");
 
   let match = text.includes("#") ? Filter.contentRegExp.exec(text) : null;
   if (match)
-  {
-    let propsMatch;
-    if (!match[2] && match[3].includes("[-") &&
-        (propsMatch = /\[-abp-properties=(["'])([^"']+)\1\]/.exec(match[3])))
-    {
-      // This is legacy CSS properties syntax, convert to current syntax
-      let prefix = match[3].substr(0, propsMatch.index);
-      let expression = propsMatch[2];
-      let suffix = match[3].substr(propsMatch.index + propsMatch[0].length);
-      return Filter.fromText(`${match[1]}#?#` +
-          `${prefix}:-abp-properties(${expression})${suffix}`);
-    }
-
     filter = ContentFilter.fromText(text, match[1], match[2], match[3]);
-  }
   else if (text[0] == "!")
     filter = new CommentFilter(text);
   else
     filter = RegExpFilter.fromText(text);
 
   Filter.knownFilters.set(filter.text, filter);
   return filter;
 };
 
 /**
@@ skipping 1034 matching lines @@
 
   /**
    * Script that should be executed
    * @type {string}
    */
   get script()
   {
     return this.body;
   }
 });