Issue 6870 - Remove support for legacy :-abp-properties() syntax

Issue 6870 - Drop support for legacy special selector syntax

[Jon Sonesen, 2018-08-25 05:01:19]

Wasn't sure whether we should still check for the old syntax and refuse the
filter or not so I went with this first but I am happy to do either. I would
just return an invalid filter and then I could write a test for it but I don't
think that there is a defined reason for this type of invalid filter to have a
useful error message for the options page.

[Manish Jethani, 2018-08-25 07:31:10]

I think we could use the title of issue #6870 as the commit message, it's a lot
more specific.

https://codereview.adblockplus.org/29863644/diff/29864555/lib/filterClasses.js
File lib/filterClasses.js (right):

https://codereview.adblockplus.org/29863644/diff/29864555/lib/filterClasses.j...
lib/filterClasses.js:125: if
(/\[-abp-properties=(["'])([^"']+)\1\]/i.test(text))
This would be nice to do, but we simply cannot afford this for performance
reasons. In fact the very reason for setting this issue to P2 is because it's so
important for the performance of this function (which really matters on mobile
or so they tell me).

https://codereview.adblockplus.org/29863644/diff/29864555/test/filterClasses.js
File test/filterClasses.js (left):

https://codereview.adblockplus.org/29863644/diff/29864555/test/filterClasses....
test/filterClasses.js:398: // test matching -abp-properties=
(https://issues.adblockplus.org/ticket/5037).
We can remove this following test as well.

[Jon Sonesen, 2018-08-27 21:32:22]

Comments addressed, thanks!

https://codereview.adblockplus.org/29863644/diff/29864555/lib/filterClasses.js
File lib/filterClasses.js (right):

https://codereview.adblockplus.org/29863644/diff/29864555/lib/filterClasses.j...
lib/filterClasses.js:125: if
(/\[-abp-properties=(["'])([^"']+)\1\]/i.test(text))
On 2018/08/25 07:31:10, Manish Jethani wrote:
> This would be nice to do, but we simply cannot afford this for performance
> reasons. In fact the very reason for setting this issue to P2 is because it's
so
> important for the performance of this function (which really matters on mobile
> or so they tell me).

Done.

https://codereview.adblockplus.org/29863644/diff/29864555/test/filterClasses.js
File test/filterClasses.js (left):

https://codereview.adblockplus.org/29863644/diff/29864555/test/filterClasses....
test/filterClasses.js:398: // test matching -abp-properties=
(https://issues.adblockplus.org/ticket/5037).
On 2018/08/25 07:31:10, Manish Jethani wrote:
> We can remove this following test as well.

Done.

[Manish Jethani, 2018-08-27 21:42:47]

https://codereview.adblockplus.org/29863644/diff/29866595/lib/filterClasses.js
File lib/filterClasses.js (left):

https://codereview.adblockplus.org/29863644/diff/29866595/lib/filterClasses.j...
lib/filterClasses.js:123: if (filter)
I'm not sure why you removed this because this is very much necessary.

[Jon Sonesen, 2018-08-27 21:49:01]

https://codereview.adblockplus.org/29863644/diff/29866595/lib/filterClasses.js
File lib/filterClasses.js (left):

https://codereview.adblockplus.org/29863644/diff/29866595/lib/filterClasses.j...
lib/filterClasses.js:123: if (filter)
On 2018/08/27 21:42:46, Manish Jethani wrote:
> I'm not sure why you removed this because this is very much necessary.

Dang wth I didn't mean to do that

[Manish Jethani, 2018-08-27 21:56:00]

LGTM