Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29864558: Issue 6882 - always shutdown the browser gracefully (Closed)

Created:
Aug. 25, 2018, 9:27 a.m. by tlucas
Modified:
Aug. 25, 2018, 10:04 a.m.
Reviewers:
Sebastian Noack
CC:
kzar, hub
Visibility:
Public.

Description

Issue 6882 - always shutdown the browser gracefully

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M test/firefox.js View 1 chunk +3 lines, -9 lines 2 comments Download

Messages

Total messages: 2
tlucas
https://codereview.adblockplus.org/29864558/diff/29864559/test/firefox.js File test/firefox.js (right): https://codereview.adblockplus.org/29864558/diff/29864559/test/firefox.js#newcode99 test/firefox.js:99: err => driver.quit().then(() => { throw err; }) Our ...
Aug. 25, 2018, 9:36 a.m. (2018-08-25 09:36:02 UTC) #1
Sebastian Noack
Aug. 25, 2018, 9:51 a.m. (2018-08-25 09:51:38 UTC) #2
LGTM.

Note that we have to address the same issue as well in adblockpluscore.

https://codereview.adblockplus.org/29864558/diff/29864559/test/firefox.js
File test/firefox.js (right):

https://codereview.adblockplus.org/29864558/diff/29864559/test/firefox.js#new...
test/firefox.js:99: err => driver.quit().then(() => { throw err; })
On 2018/08/25 09:36:01, tlucas wrote:
> Our coding-style (https://adblockplus.org/en/coding-style @ "General") tells
us
> to always put opening braces on their own line.
> 
> I looked for exceptions, but found none. Do we practice this even in this
case,
> where newlines would unnecessarily (imho) mess up readability?

One liners are fine too.

Powered by Google App Engine
This is Rietveld