Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29866650: Noissue - Remove unused linesProcessed property of INIParser (Closed)

Created:
Aug. 27, 2018, 9:39 p.m. by Manish Jethani
Modified:
Aug. 29, 2018, 12:35 p.m.
Reviewers:
hub, Jon Sonesen
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

This property is not being used at all. Update: This was taken care of in Trac issue #6893.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M lib/filterStorage.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5
Manish Jethani
Aug. 27, 2018, 9:39 p.m. (2018-08-27 21:39:23 UTC) #1
Manish Jethani
Patch Set 1
Aug. 27, 2018, 9:40 p.m. (2018-08-27 21:40:14 UTC) #2
hub
On 2018/08/27 21:40:14, Manish Jethani wrote: > Patch Set 1 this will need to be ...
Aug. 29, 2018, 3:42 a.m. (2018-08-29 03:42:57 UTC) #3
Jon Sonesen
Nice catch! LGTM
Aug. 29, 2018, 5:56 a.m. (2018-08-29 05:56:18 UTC) #4
Jon Sonesen
Aug. 29, 2018, 5:57 a.m. (2018-08-29 05:57:19 UTC) #5
On 2018/08/29 05:56:18, Jon Sonesen wrote:
> Nice catch!
> 
> LGTM
oh man, my bad the rebase :/

Powered by Google App Engine
This is Rietveld