Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29867569: Issue 6893, 6741 - Split out INIParser into its own file (Closed)

Created:
Aug. 28, 2018, 11:52 a.m. by Manish Jethani
Modified:
Aug. 29, 2018, 12:33 p.m.
Reviewers:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Make internal properties private #

Patch Set 3 : Fix inconsistencies in brace usage #

Patch Set 4 : Fix ESLint error #

Patch Set 5 : Move definition of match variable inside try block #

Patch Set 6 : Rename val argument to value #

Patch Set 7 : Insert blank lines for readability #

Patch Set 8 : Add JSDoc comments #

Patch Set 9 : Rename value argument to line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -98 lines) Patch
M lib/filterStorage.js View 2 chunks +1 line, -98 lines 0 comments Download
A lib/iniParser.js View 1 2 3 4 5 6 7 8 1 chunk +153 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Manish Jethani
Aug. 28, 2018, 11:52 a.m. (2018-08-28 11:52:54 UTC) #1
Manish Jethani
Patch Set 1..9 I have deliberately made the changes incrementally so they are easier to ...
Aug. 28, 2018, 12:51 p.m. (2018-08-28 12:51:12 UTC) #2
hub
Aug. 29, 2018, 3:42 a.m. (2018-08-29 03:42:09 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld