Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29869555: Issue 6862 - Add tests for Snippets module events (Closed)

Created:
Aug. 30, 2018, 10:24 a.m. by Manish Jethani
Modified:
Aug. 30, 2018, 5:46 p.m.
Reviewers:
Jon Sonesen
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

In a previous commit [1] we added events for the Snippets module. This patch adds tests for the events. [1]: https://hg.adblockplus.org/adblockpluscore/rev/7d7fd250e8f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M test/snippets.js View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Manish Jethani
Aug. 30, 2018, 10:24 a.m. (2018-08-30 10:24:34 UTC) #1
Manish Jethani
Patch Set 1 Can you do a quick review for me?
Aug. 30, 2018, 10:26 a.m. (2018-08-30 10:26:33 UTC) #2
Jon Sonesen
Aug. 30, 2018, 3:32 p.m. (2018-08-30 15:32:43 UTC) #3
Hey Manish,
Thanks for adding these LGTM!

Powered by Google App Engine
This is Rietveld