Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29869574: Issue 6883 - Use filterToRegExp in lib/filterClasses.js (Closed)

Created:
Aug. 30, 2018, 4:22 p.m. by Jon Sonesen
Modified:
Aug. 31, 2018, 5:20 a.m.
Reviewers:
Manish Jethani
CC:
Thomas Greiner, kzar, Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 6883 - Use filterToRegExp in lib/filterClasses.js Remove unused declaration of Filter.toRegExp and call filterToRegExp directly cc'd folks from the ticket since not everyone said whether they object or not.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M lib/filterClasses.js View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 2
Jon Sonesen
Aug. 30, 2018, 4:22 p.m. (2018-08-30 16:22:31 UTC) #1
Manish Jethani
Aug. 30, 2018, 5:37 p.m. (2018-08-30 17:37:28 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld