Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29870574: Noissue - Define RegExpFilter's 0 getter statically (Closed)

Created:
Sept. 1, 2018, 3:05 a.m. by Manish Jethani
Modified:
Sept. 3, 2018, 10:41 a.m.
Reviewers:
Jon Sonesen
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M lib/filterClasses.js View 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 3
Manish Jethani
Sept. 1, 2018, 3:05 a.m. (2018-09-01 03:05:47 UTC) #1
Manish Jethani
Patch Set 1 I checked and the performance is the same, it's just better to ...
Sept. 1, 2018, 3:06 a.m. (2018-09-01 03:06:44 UTC) #2
Jon Sonesen
Sept. 2, 2018, 5:13 p.m. (2018-09-02 17:13:28 UTC) #3
Yeah static is much nicer, LGTM

Powered by Google App Engine
This is Rietveld