Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29870577: Issue 6916 - Encapsulate filter subscriptions (Closed)

Created:
Sept. 1, 2018, 4:53 a.m. by Manish Jethani
Modified:
Sept. 4, 2018, 3:03 p.m.
Reviewers:
sergei, Jon Sonesen, hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

See https://codereview.adblockplus.org/29871555/

Patch Set 1 #

Patch Set 2 : Add JSDoc for addSubscription and removeSubscription #

Patch Set 3 : Add subscriptionCount property #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -22 lines) Patch
M lib/filterClasses.js View 1 2 1 chunk +45 lines, -7 lines 0 comments Download
M lib/filterListener.js View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/filterStorage.js View 4 chunks +6 lines, -6 lines 0 comments Download
M lib/iniParser.js View 1 chunk +1 line, -1 line 0 comments Download
M test/filterListener.js View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M test/filterStorage.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Manish Jethani
Sept. 1, 2018, 4:53 a.m. (2018-09-01 04:53:22 UTC) #1
Manish Jethani
Patch Set 1
Sept. 1, 2018, 5:21 a.m. (2018-09-01 05:21:41 UTC) #2
Manish Jethani
Patch Set 2: Add JSDoc for addSubscription and removeSubscription Patch Set 3: Add subscriptionCount property
Sept. 1, 2018, 2:31 p.m. (2018-09-01 14:31:17 UTC) #3
hub
Sept. 4, 2018, 2:56 p.m. (2018-09-04 14:56:31 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld