Noissue - Fixed "$xmlhttprequest Exception" test case

Noissue - Fixed "$xmlhttprequest Exception" test case

[Sebastian Noack, 2018-09-01 19:30:48]

There were several issues with this test case:

1. It never gave the expected output to begin with, since the (whitelisted)
   XHR never went through due to mixed content (requesting unencrypted HTTP
   from a page delivered over HTTPS).
2. The image that is supposed to be blocked, wasn't indicated accordingly
   for the automation.
3. The expected result of successfully performing the XHR wasn't indicated
   in a machine-readable way for the automation (i.e. there was no element
   with the ID "testcase-output-expected").

https://codereview.adblockplus.org/29871625/diff/29871626/pages/exceptions/xm...
File pages/exceptions/xmlhttprequest.tmpl (left):

https://codereview.adblockplus.org/29871625/diff/29871626/pages/exceptions/xm...
pages/exceptions/xmlhttprequest.tmpl:51:
<pre>||testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/*</pre>
There were several issues with this test case:

1. It never gave the expected output to begin with, since the (whitelisted)
   XHR never went through due to mixed content (requesting unencrypted HTTP
   from a page delivered over HTTPS).
2. The image that is supposed to be blocked, wasn't indicated accordingly
   for the automation.
3. The expected result of successfully performing the XHR wasn't indicated
   in a machine-readable way for the automation (i.e. there was no element with
the ID "testcase-output-expected").

[rossg, 2018-09-03 10:51:32]

On 2018/09/01 19:30:48, Sebastian Noack wrote:
> There were several issues with this test case:
> 
> 1. It never gave the expected output to begin with, since the (whitelisted)
>    XHR never went through due to mixed content (requesting unencrypted HTTP
>    from a page delivered over HTTPS).
> 2. The image that is supposed to be blocked, wasn't indicated accordingly
>    for the automation.
> 3. The expected result of successfully performing the XHR wasn't indicated
>    in a machine-readable way for the automation (i.e. there was no element
>    with the ID "testcase-output-expected").
> 
>
https://codereview.adblockplus.org/29871625/diff/29871626/pages/exceptions/xm...
> File pages/exceptions/xmlhttprequest.tmpl (left):
> 
>
https://codereview.adblockplus.org/29871625/diff/29871626/pages/exceptions/xm...
> pages/exceptions/xmlhttprequest.tmpl:51:
> <pre>||testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/*</pre>
> There were several issues with this test case:
> 
> 1. It never gave the expected output to begin with, since the (whitelisted)
>    XHR never went through due to mixed content (requesting unencrypted HTTP
>    from a page delivered over HTTPS).
> 2. The image that is supposed to be blocked, wasn't indicated accordingly
>    for the automation.
> 3. The expected result of successfully performing the XHR wasn't indicated
>    in a machine-readable way for the automation (i.e. there was no element
with
> the ID "testcase-output-expected").

Thank you for this. I hadn't got to fixing this one yet.

[rossg, 2018-09-03 10:51:45]

LGTM