Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29874564: Issue 6926 - Set "siteurl" to "localhost:5000" in testserver (Closed)

Sept. 4, 2018, 1:44 p.m. by Vasily Kuznetsov
Sept. 6, 2018, 4:29 p.m.


Issue 6926 - Set "siteurl" to "localhost:5000" in testserver Repository: https://hg.adblockplus.org/cms Base revision: c83c3ae1854c The original issue is at: https://gitlab.com/eyeo/websites/cms/issues/3

Patch Set 1 : Initial #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M cms/bin/test_server.py View 1 chunk +2 lines, -1 line 0 comments Download
M docs/api/variables.md View 1 chunk +8 lines, -4 lines 0 comments Download
M tests/expected_output/en/sitemap View 1 chunk +1 line, -0 lines 0 comments Download
A tests/expected_output/en/siteurl@dynamic View 1 chunk +1 line, -0 lines 0 comments Download
A tests/expected_output/en/siteurl@static View 1 chunk +1 line, -0 lines 0 comments Download
A tests/test_site/pages/siteurl.tmpl View 1 chunk +1 line, -0 lines 0 comments Download
M tests/test_site/settings.ini View 1 chunk +1 line, -1 line 0 comments Download


Total messages: 3
Vasily Kuznetsov
Hi guys! Here are the tests and documentation for the feature that solves the issue. ...
Sept. 4, 2018, 2:18 p.m. (2018-09-04 14:18:11 UTC) #1
Jon Sonesen
On 2018/09/04 14:18:11, Vasily Kuznetsov wrote: > Hi guys! > > Here are the tests ...
Sept. 5, 2018, 2:12 p.m. (2018-09-05 14:12:12 UTC) #2
Vasily Kuznetsov
Sept. 5, 2018, 2:31 p.m. (2018-09-05 14:31:16 UTC) #3
On 2018/09/05 14:12:12, Jon Sonesen wrote:

>  Moving forward though we need to commit to using *either* gitlab
> or http://issues.adblockplus.org two issue tickets one created by Julian then
> created by you is quite redundant and not in the "let's back up my hard drive
> times to be safe" kind of way but more like "we like to do twice the work for
> single outcome" kind of way. 

Definitely, man! My current thinking is that issues.adblockplus.org would stay
the main tracker until the master repository is moved to gitlab.com (and we pray
to Ops for this to happen soon). Likewise the reviews would take place here.
After the master repo moves to gitlab (with hg.adblockplus.org becoming a
replica) we will move all outstanding tickets there and discourage creation of
new tickets on issues.adblockplus.org (this should be easy -- none of CMS
stakeholders really want to create tickets there anyway). Reivews would also
move to gitlab and we'll spin up CI to automate the job of reviewers a bit.

Does this make sense?

Powered by Google App Engine
This is Rietveld