Issue 6926 - Set "siteurl" to "localhost:5000" in testserver

Issue 6926 - Set "siteurl" to "localhost:5000" in testserver

Repository: https://hg.adblockplus.org/cms
Base revision: c83c3ae1854c

The original issue is at: https://gitlab.com/eyeo/websites/cms/issues/3

[Vasily Kuznetsov, 2018-09-04 14:18:11]

Hi guys!

Here are the tests and documentation for the feature that solves the issue. I
have also made the code a bit prettier, but the functionality was actually
already there.

Let me know what you think.

Cheers,
Vasily

[Jon Sonesen, 2018-09-05 14:12:12]

On 2018/09/04 14:18:11, Vasily Kuznetsov wrote:
> Hi guys!
> 
> Here are the tests and documentation for the feature that solves the issue. I
> have also made the code a bit prettier, but the functionality was actually
> already there.
> 
> Let me know what you think.
> 
> Cheers,
> Vasily

Hey Vasily, this is great! Thanks for testing and documenting this
functionality. Moving forward though we need to commit to using *either* gitlab
or issues.adblockplus.org two issue tickets one created by Julian then later
created by you is quite redundant and not in the "let's back up my hard drive 5
times to be safe" kind of way but more like "we like to do twice the work for a
single outcome" kind of way. 

I know that it is not hard to make a proxy ticket but it just adds to the
confusion/workflow of the people who come after us.

LGTM

Cheers,

Jon

[Vasily Kuznetsov, 2018-09-05 14:31:16]

On 2018/09/05 14:12:12, Jon Sonesen wrote:

>  Moving forward though we need to commit to using *either* gitlab
> or http://issues.adblockplus.org two issue tickets one created by Julian then
later
> created by you is quite redundant and not in the "let's back up my hard drive
5
> times to be safe" kind of way but more like "we like to do twice the work for
a
> single outcome" kind of way. 

Definitely, man! My current thinking is that issues.adblockplus.org would stay
the main tracker until the master repository is moved to gitlab.com (and we pray
to Ops for this to happen soon). Likewise the reviews would take place here.
After the master repo moves to gitlab (with hg.adblockplus.org becoming a
replica) we will move all outstanding tickets there and discourage creation of
new tickets on issues.adblockplus.org (this should be easy -- none of CMS
stakeholders really want to create tickets there anyway). Reivews would also
move to gitlab and we'll spin up CI to automate the job of reviewers a bit.

Does this make sense?