Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29874589: Issue 6927 - Expose pattern from RegExpFilter (Closed)

Created:
Sept. 4, 2018, 2:41 p.m. by Manish Jethani
Modified:
Sept. 4, 2018, 5:28 p.m.
Reviewers:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 6927 - Expose pattern from RegExpFilter

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -23 lines) Patch
M lib/filterClasses.js View 1 3 chunks +4 lines, -10 lines 0 comments Download
M lib/matcher.js View 2 chunks +4 lines, -13 lines 0 comments Download

Messages

Total messages: 5
Manish Jethani
Sept. 4, 2018, 2:41 p.m. (2018-09-04 14:41:33 UTC) #1
Manish Jethani
Patch Set 1 https://codereview.adblockplus.org/29874589/diff/29874590/lib/filterClasses.js File lib/filterClasses.js (left): https://codereview.adblockplus.org/29874589/diff/29874590/lib/filterClasses.js#oldcode101 lib/filterClasses.js:101: Filter.regexpRegExp = /^(@@)?\/.*\/(?:\$~?[\w-]+(?:=[^,\s]+)?(?:,~?[\w-]+(?:=[^,\s]+)?)*)?$/; This appears not ...
Sept. 4, 2018, 2:50 p.m. (2018-09-04 14:50:47 UTC) #2
hub
LGTM
Sept. 4, 2018, 4:33 p.m. (2018-09-04 16:33:25 UTC) #3
Manish Jethani
Patch Set 2: Rebase Sorry, there's a rebase. The significant part is in the regexp ...
Sept. 4, 2018, 4:54 p.m. (2018-09-04 16:54:48 UTC) #4
hub
Sept. 4, 2018, 5 p.m. (2018-09-04 17:00:55 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld