Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29874607: Issue 6769 - Avoid hardcoding the URL (Closed)

Created:
Sept. 4, 2018, 4:23 p.m. by kzar
Modified:
Sept. 25, 2018, 3:04 p.m.
Reviewers:
Sebastian Noack, rossg
Visibility:
Public.

Description

Issue 6769 - Avoid hardcoding the URL

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed some mistakes #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -329 lines) Patch
M README.md View 1 chunk +1 line, -2 lines 0 comments Download
A filters/domain.py View 1 chunk +4 lines, -0 lines 0 comments Download
A filters/strip_proto.py View 1 chunk +2 lines, -0 lines 0 comments Download
D includes/testcases.md View 1 chunk +0 lines, -151 lines 0 comments Download
A + includes/testcases.tmpl View 2 chunks +3 lines, -3 lines 0 comments Download
A pages/abp-testcase-subscription.txt.tmpl View 1 2 1 chunk +97 lines, -0 lines 0 comments Download
M pages/exceptions/document.tmpl View 1 1 chunk +4 lines, -4 lines 0 comments Download
M pages/exceptions/element-hiding.tmpl View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pages/exceptions/elemhide.tmpl View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pages/exceptions/image.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M pages/exceptions/popup.tmpl View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M pages/exceptions/script.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M pages/exceptions/stylesheet.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M pages/exceptions/subdocument.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M pages/exceptions/xmlhttprequest.tmpl View 1 2 chunks +3 lines, -3 lines 0 comments Download
M pages/filters/blocking.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M pages/filters/element-hiding.tmpl View 1 11 chunks +12 lines, -12 lines 0 comments Download
M pages/filters/element-hiding-emulation.tmpl View 1 8 chunks +8 lines, -8 lines 0 comments Download
M pages/filters/image.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M pages/filters/object.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M pages/filters/object-subrequest.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M pages/filters/ping.tmpl View 2 chunks +3 lines, -3 lines 0 comments Download
M pages/filters/popup.tmpl View 2 chunks +3 lines, -3 lines 0 comments Download
M pages/filters/script.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M pages/filters/stylesheet.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M pages/filters/subdocument.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M pages/filters/webrtc.tmpl View 1 1 chunk +1 line, -1 line 0 comments Download
M pages/filters/websocket.tmpl View 1 1 chunk +1 line, -1 line 0 comments Download
M pages/filters/xmlhttprequest.tmpl View 1 2 chunks +2 lines, -2 lines 0 comments Download
A pages/frames/testcase-img-05.tmpl View 1 1 chunk +11 lines, -0 lines 0 comments Download
M settings.ini View 1 chunk +1 line, -0 lines 0 comments Download
D static/abp-testcase-subscription.txt View 1 chunk +0 lines, -97 lines 0 comments Download
M static/frames/testcase-img-05.html View 1 1 chunk +0 lines, -13 lines 0 comments Download
A templates/plaintext.tmpl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10
kzar
Patch Set 1 I've not carefully checked through and tested these changes yet, I'll have ...
Sept. 4, 2018, 4:25 p.m. (2018-09-04 16:25:12 UTC) #1
Sebastian Noack
Just in case, did you try running "npm test" from the "next" branch in "adblockpluschrome" ...
Sept. 4, 2018, 4:45 p.m. (2018-09-04 16:45:56 UTC) #2
kzar
Patch Set 2 : Fixed some mistakes > I've not carefully checked through and tested ...
Sept. 5, 2018, 5:02 p.m. (2018-09-05 17:02:52 UTC) #3
Sebastian Noack
Would you mind rebasing these changes?
Sept. 19, 2018, 11:28 a.m. (2018-09-19 11:28:39 UTC) #4
kzar
Patch Set 3: Rebased OK, there you go, I've put the line endings of the ...
Sept. 24, 2018, 1:40 p.m. (2018-09-24 13:40:20 UTC) #5
Sebastian Noack
Thanks, I could download and apply the patch from GitHub. But with the test automation ...
Sept. 24, 2018, 3:56 p.m. (2018-09-24 15:56:29 UTC) #6
kzar
On 2018/09/24 15:56:29, Sebastian Noack wrote: > Thanks, I could download and apply the patch ...
Sept. 25, 2018, 11:15 a.m. (2018-09-25 11:15:53 UTC) #7
Sebastian Noack
On 2018/09/25 11:15:53, kzar wrote: > On 2018/09/24 15:56:29, Sebastian Noack wrote: > > Thanks, ...
Sept. 25, 2018, 12:02 p.m. (2018-09-25 12:02:52 UTC) #8
kzar
On 2018/09/25 12:02:52, Sebastian Noack wrote: > On 2018/09/25 11:15:53, kzar wrote: > > On ...
Sept. 25, 2018, 1:12 p.m. (2018-09-25 13:12:04 UTC) #9
Sebastian Noack
Sept. 25, 2018, 1:56 p.m. (2018-09-25 13:56:05 UTC) #10
On 2018/09/25 13:12:04, kzar wrote:
> All the tests pass for me with 0db859ce10b2 and the TEST_PAGES_URL of
> "http://localhost:5000/en/" intermittently. I suspect there are some problems
> with the test automation that are causing the occasional fails. Does it fail
for
> your consistently? Does it work consistently without the TEST_PAGES_URL
change?

The problem was that I set TEST_PAGES_URL to "http://localhost:5000/". If I set
it to "http://localhost:5000/en/" the tests pass. LGTM.

Powered by Google App Engine
This is Rietveld