Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(574)

Issue 29874607: Issue 6769 - Avoid hardcoding the URL

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 1 day ago by kzar
Modified:
6 hours, 58 minutes ago
Reviewers:
Sebastian Noack, rossg
Visibility:
Public.

Description

Issue 6769 - Avoid hardcoding the URL

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed some mistakes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -330 lines) Patch
M README.md View 1 chunk +1 line, -2 lines 0 comments Download
A filters/domain.py View 1 chunk +4 lines, -0 lines 0 comments Download
A filters/strip_proto.py View 1 chunk +2 lines, -0 lines 0 comments Download
D includes/testcases.md View 1 chunk +0 lines, -151 lines 0 comments Download
A + includes/testcases.tmpl View 2 chunks +3 lines, -3 lines 0 comments Download
A pages/abp-testcase-subscription.txt.tmpl View 1 1 chunk +97 lines, -0 lines 0 comments Download
M pages/exceptions/document.tmpl View 1 1 chunk +4 lines, -4 lines 0 comments Download
M pages/exceptions/element-hiding.tmpl View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pages/exceptions/elemhide.tmpl View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pages/exceptions/image.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M pages/exceptions/popup.tmpl View 2 chunks +5 lines, -5 lines 0 comments Download
M pages/exceptions/script.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M pages/exceptions/stylesheet.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M pages/exceptions/subdocument.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M pages/exceptions/xmlhttprequest.tmpl View 1 2 chunks +3 lines, -3 lines 0 comments Download
M pages/filters/blocking.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M pages/filters/element-hiding.tmpl View 1 11 chunks +12 lines, -12 lines 0 comments Download
M pages/filters/element-hiding-emulation.tmpl View 1 8 chunks +8 lines, -8 lines 0 comments Download
M pages/filters/image.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M pages/filters/object.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M pages/filters/object-subrequest.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M pages/filters/ping.tmpl View 2 chunks +3 lines, -3 lines 0 comments Download
M pages/filters/popup.tmpl View 2 chunks +3 lines, -3 lines 0 comments Download
M pages/filters/script.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M pages/filters/stylesheet.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M pages/filters/subdocument.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M pages/filters/webrtc.tmpl View 1 1 chunk +1 line, -1 line 0 comments Download
M pages/filters/websocket.tmpl View 1 1 chunk +1 line, -1 line 0 comments Download
M pages/filters/xmlhttprequest.tmpl View 1 2 chunks +2 lines, -2 lines 0 comments Download
A pages/frames/testcase-img-05.tmpl View 1 1 chunk +11 lines, -0 lines 0 comments Download
M settings.ini View 1 chunk +1 line, -0 lines 0 comments Download
D static/abp-testcase-subscription.txt View 1 chunk +0 lines, -97 lines 0 comments Download
M static/frames/testcase-img-05.html View 1 1 chunk +0 lines, -13 lines 0 comments Download
A templates/plaintext.tmpl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1 I've not carefully checked through and tested these changes yet, I'll have ...
2 weeks, 1 day ago (2018-09-04 16:25:12 UTC) #1
Sebastian Noack
Just in case, did you try running "npm test" from the "next" branch in "adblockpluschrome" ...
2 weeks, 1 day ago (2018-09-04 16:45:56 UTC) #2
kzar
Patch Set 2 : Fixed some mistakes > I've not carefully checked through and tested ...
2 weeks ago (2018-09-05 17:02:52 UTC) #3
Sebastian Noack
6 hours, 58 minutes ago (2018-09-19 11:28:39 UTC) #4
Would you mind rebasing these changes?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5