Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(597)

Issue 29876558: Issue 6913 Some test cases fail on Microsoft Edge (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 6 days ago by geo
Modified:
2 days, 2 hours ago
Reviewers:
Sebastian Noack, kzar
Visibility:
Public.

Description

-removed "Extracting hostname from URL" test -moved "Extracting hostname from URL with auth credentials" to "URL/host tools" -skipped the failing test cases due to bugs in Edge on this platform

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -27 lines) Patch
M qunit/tests/url.js View 1 2 chunks +16 lines, -27 lines 0 comments Download

Messages

Total messages: 4
geo
https://codereview.adblockplus.org/29876558/diff/29876559/qunit/tests/url.js File qunit/tests/url.js (right): https://codereview.adblockplus.org/29876558/diff/29876559/qunit/tests/url.js#newcode21 qunit/tests/url.js:21: const {extractHostFromFrame, I know that this change is not ...
1 week, 6 days ago (2018-09-06 10:24:10 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29876558/diff/29876559/qunit/tests/url.js File qunit/tests/url.js (right): https://codereview.adblockplus.org/29876558/diff/29876559/qunit/tests/url.js#newcode21 qunit/tests/url.js:21: const {extractHostFromFrame, On 2018/09/06 10:24:10, geo wrote: > I ...
1 week, 6 days ago (2018-09-06 13:43:21 UTC) #2
geo
https://codereview.adblockplus.org/29876558/diff/29876559/qunit/tests/url.js File qunit/tests/url.js (right): https://codereview.adblockplus.org/29876558/diff/29876559/qunit/tests/url.js#newcode21 qunit/tests/url.js:21: const {extractHostFromFrame, On 2018/09/06 13:43:21, Sebastian Noack wrote: > ...
1 week, 5 days ago (2018-09-06 20:10:47 UTC) #3
Sebastian Noack
1 week, 5 days ago (2018-09-06 21:49:35 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5