Issue 6933 - Update adblockpluscore dependency to hg:dcda4859fcbd

[Manish Jethani, 2018-09-10 18:01:40]

Patch Set 1

Not sure if there's an issue for this, but these are the changes needed for the
dependency update for ABP 3.4.

https://codereview.adblockplus.org/29877564/diff/29877565/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29877564/diff/29877565/dependencies#newcode5
dependencies:5: adblockplusui = adblockplusui hg:efea71d85b24 git:67288d7
This would have to include a dependency update for adblockplusui as well, once
we have the changeset hash.

[Manish Jethani, 2018-09-10 18:05:26]

Patch Set 2: Modify callback for subscription.removed (#6908)

[Sebastian Noack, 2018-09-10 18:15:46]

It seems you missed the recently added lib/indexedDBBackup.js.

On 2018/09/10 18:01:40, Manish Jethani wrote:
> Patch Set 1
> 
> Not sure if there's an issue for this, but these are the changes needed for
the
> dependency update for ABP 3.4.

There is: https://issues.adblockplus.org/ticket/6933

Mind updating the issue description with the changes pulled in from
adblockpluscore?

[Thomas Greiner, 2018-09-11 13:19:26]

https://codereview.adblockplus.org/29877564/diff/29877565/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29877564/diff/29877565/dependencies#newcode5
dependencies:5: adblockplusui = adblockplusui hg:efea71d85b24 git:67288d7
On 2018/09/10 18:01:40, Manish Jethani wrote:
> This would have to include a dependency update for adblockplusui as well, once
> we have the changeset hash.

I've pushed the necessary UI changes to Mercurial and added the hashes to the
ticket description in #6933.

[Manish Jethani, 2018-09-11 13:41:42]

On 2018/09/10 18:15:46, Sebastian Noack wrote:
> It seems you missed the recently added lib/indexedDBBackup.js.

Sorry, this was on master. I've rebased on next now and included the changes for
this file as well.

> On 2018/09/10 18:01:40, Manish Jethani wrote:
> > Patch Set 1
> > 
> > Not sure if there's an issue for this, but these are the changes needed for
> the
> > dependency update for ABP 3.4.
> 
> There is: https://issues.adblockplus.org/ticket/6933
> 
> Mind updating the issue description with the changes pulled in from
> adblockpluscore?

I'll do that shortly.

[Manish Jethani, 2018-09-11 13:43:38]

Patch Set 3: Rebase on next and update adblockplusui dependency

https://codereview.adblockplus.org/29877564/diff/29878555/lib/requestBlocker.js
File lib/requestBlocker.js (right):

https://codereview.adblockplus.org/29877564/diff/29878555/lib/requestBlocker....
lib/requestBlocker.js:332: filterNotifier.on("subscription.removed", arg =>
onFilterChange(arg, false));
Everything else is just simple renaming of things, while this is worth noting:
subscription.removed will get the old filters of the subscription (array) as its
second argument, so here we need to explicitly pass false (or not pass anything,
though I chose to do the former).

[Sebastian Noack, 2018-09-11 13:51:24]

https://codereview.adblockplus.org/29877564/diff/29878555/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29877564/diff/29878555/dependencies#newcode4
dependencies:4: adblockpluscore = adblockpluscore hg:39fbb0b12cc3 git:1bef20d
Any reason we don't update to the latest revision of core?

[Manish Jethani, 2018-09-11 14:12:04]

Patch Set 4: Update core to hg:dcda4859fcbd git:c9dc573

https://codereview.adblockplus.org/29877564/diff/29878555/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29877564/diff/29878555/dependencies#newcode4
dependencies:4: adblockpluscore = adblockpluscore hg:39fbb0b12cc3 git:1bef20d
On 2018/09/11 13:51:22, Sebastian Noack wrote:
> Any reason we don't update to the latest revision of core?

No reason, done.

[Sebastian Noack, 2018-09-11 14:55:42]

LGTM