Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29879555: Issue 6892 - Update adblockplusui dependency to hg:7386698260f4 (Closed)

Created:
Sept. 13, 2018, 10:53 a.m. by Thomas Greiner
Modified:
Sept. 13, 2018, 4:32 p.m.
Reviewers:
Sebastian Noack, kzar
CC:
a.giammarchi, saroyanm
Visibility:
Public.

Description

This review contains the following changes: - Updated adblockplusui dependency - #5914 - Import icons used for screenshot feature in issue reporter - #6633 - Moved translatable strings to adblockplusui - #6749 - Updated imports for new first-run page - #6794 - Moved popup to adblockplusui

Patch Set 1 #

Total comments: 6

Patch Set 2 : Removed import of LICENSE-3RD-PARTY.txt #

Patch Set 3 : Updated adblockplusui dependency to include preliminary translations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -9266 lines) Patch
R _locales/af/messages.json View 1 chunk +0 lines, -29 lines 0 comments Download
R _locales/am/messages.json View 1 chunk +0 lines, -88 lines 0 comments Download
R _locales/ar/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/as/messages.json View 1 chunk +0 lines, -5 lines 0 comments Download
R _locales/ast/messages.json View 1 chunk +0 lines, -17 lines 0 comments Download
R _locales/az/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/be/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/bg/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/bn/messages.json View 1 chunk +0 lines, -124 lines 0 comments Download
R _locales/br/messages.json View 1 chunk +0 lines, -29 lines 0 comments Download
R _locales/bs/messages.json View 1 chunk +0 lines, -26 lines 0 comments Download
R _locales/ca/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/cs/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/cy/messages.json View 1 chunk +0 lines, -29 lines 0 comments Download
R _locales/da/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/de/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/dsb/messages.json View 1 chunk +0 lines, -35 lines 0 comments Download
R _locales/el/messages.json View 1 chunk +0 lines, -121 lines 0 comments Download
R _locales/en_GB/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/en_US/messages.json View 1 chunk +0 lines, -149 lines 0 comments Download
R _locales/eo/messages.json View 1 chunk +0 lines, -35 lines 0 comments Download
R _locales/es/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/es_AR/messages.json View 1 chunk +0 lines, -121 lines 0 comments Download
R _locales/es_CL/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/es_MX/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/et/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/eu/messages.json View 1 chunk +0 lines, -124 lines 0 comments Download
R _locales/fa/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/fi/messages.json View 1 chunk +0 lines, -127 lines 0 comments Download
R _locales/fil/messages.json View 1 chunk +0 lines, -100 lines 0 comments Download
R _locales/fr/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/fy/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/ga/messages.json View 1 chunk +0 lines, -8 lines 0 comments Download
R _locales/gd/messages.json View 1 chunk +0 lines, -8 lines 0 comments Download
R _locales/gl/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/gu/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/he/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/hi/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/hr/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/hsb/messages.json View 1 chunk +0 lines, -35 lines 0 comments Download
R _locales/hu/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/hy/messages.json View 1 chunk +0 lines, -67 lines 0 comments Download
R _locales/id/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/is/messages.json View 1 chunk +0 lines, -35 lines 0 comments Download
R _locales/it/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/ja/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/ka/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/kab/messages.json View 1 chunk +0 lines, -124 lines 0 comments Download
R _locales/kk/messages.json View 1 chunk +0 lines, -35 lines 0 comments Download
R _locales/kn/messages.json View 1 chunk +0 lines, -97 lines 0 comments Download
R _locales/ko/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/ku/messages.json View 1 chunk +0 lines, -38 lines 0 comments Download
R _locales/lt/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/lv/messages.json View 1 chunk +0 lines, -127 lines 0 comments Download
R _locales/mk/messages.json View 1 chunk +0 lines, -32 lines 0 comments Download
R _locales/ml/messages.json View 1 chunk +0 lines, -94 lines 0 comments Download
R _locales/mr/messages.json View 1 chunk +0 lines, -99 lines 0 comments Download
R _locales/ms/messages.json View 1 chunk +0 lines, -124 lines 0 comments Download
R _locales/nb/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/nl/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/nn/messages.json View 1 chunk +0 lines, -23 lines 0 comments Download
R _locales/pl/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/pt_BR/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/pt_PT/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/ro/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/ru/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/si/messages.json View 1 chunk +0 lines, -29 lines 0 comments Download
R _locales/sk/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/sl/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/sq/messages.json View 1 chunk +0 lines, -41 lines 0 comments Download
R _locales/sr/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/sv/messages.json View 1 chunk +0 lines, -127 lines 0 comments Download
R _locales/sw/messages.json View 1 chunk +0 lines, -54 lines 0 comments Download
R _locales/ta/messages.json View 1 chunk +0 lines, -124 lines 0 comments Download
R _locales/te/messages.json View 1 chunk +0 lines, -68 lines 0 comments Download
R _locales/th/messages.json View 1 chunk +0 lines, -127 lines 0 comments Download
R _locales/tr/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/uk/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/ur/messages.json View 1 chunk +0 lines, -78 lines 0 comments Download
R _locales/uz/messages.json View 1 chunk +0 lines, -124 lines 0 comments Download
R _locales/vi/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/zh_CN/messages.json View 1 chunk +0 lines, -130 lines 0 comments Download
R _locales/zh_TW/messages.json View 1 chunk +0 lines, -124 lines 0 comments Download
M dependencies View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/subscriptionInit.js View 1 chunk +1 line, -1 line 0 comments Download
M metadata.chrome View 1 5 chunks +32 lines, -20 lines 0 comments Download
R popup.html View 1 chunk +0 lines, -105 lines 0 comments Download
R popup.js View 1 chunk +0 lines, -341 lines 0 comments Download
R skin/popup.css View 1 chunk +0 lines, -337 lines 0 comments Download
R skin/popup.png View Binary file 0 comments Download

Messages

Total messages: 7
Thomas Greiner
Sept. 13, 2018, 11:01 a.m. (2018-09-13 11:01:58 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29879555/diff/29879556/metadata.chrome File metadata.chrome (right): https://codereview.adblockplus.org/29879555/diff/29879556/metadata.chrome#newcode71 metadata.chrome:71: LICENSE-3RD-PARTY.txt = adblockplusui/LICENSE-3RD-PARTY.txt We don't include our own COPYING ...
Sept. 13, 2018, 12:11 p.m. (2018-09-13 12:11:27 UTC) #2
Thomas Greiner
https://codereview.adblockplus.org/29879555/diff/29879556/metadata.chrome File metadata.chrome (right): https://codereview.adblockplus.org/29879555/diff/29879556/metadata.chrome#newcode71 metadata.chrome:71: LICENSE-3RD-PARTY.txt = adblockplusui/LICENSE-3RD-PARTY.txt On 2018/09/13 12:11:26, Sebastian Noack wrote: ...
Sept. 13, 2018, 3:13 p.m. (2018-09-13 15:13:36 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29879555/diff/29879556/metadata.chrome File metadata.chrome (right): https://codereview.adblockplus.org/29879555/diff/29879556/metadata.chrome#newcode71 metadata.chrome:71: LICENSE-3RD-PARTY.txt = adblockplusui/LICENSE-3RD-PARTY.txt On 2018/09/13 15:13:35, Thomas Greiner wrote: ...
Sept. 13, 2018, 3:30 p.m. (2018-09-13 15:30:30 UTC) #4
Thomas Greiner
https://codereview.adblockplus.org/29879555/diff/29879556/metadata.chrome File metadata.chrome (right): https://codereview.adblockplus.org/29879555/diff/29879556/metadata.chrome#newcode71 metadata.chrome:71: LICENSE-3RD-PARTY.txt = adblockplusui/LICENSE-3RD-PARTY.txt On 2018/09/13 15:30:29, Sebastian Noack wrote: ...
Sept. 13, 2018, 4 p.m. (2018-09-13 16:00:32 UTC) #5
Thomas Greiner
As requested, I've updated the dependency again to avoid the duplicate string warning during building.
Sept. 13, 2018, 4:11 p.m. (2018-09-13 16:11:00 UTC) #6
Sebastian Noack
Sept. 13, 2018, 4:12 p.m. (2018-09-13 16:12:32 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld