Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29890555: Issue 6914 - Wrap window.frameElement in try catch to silence Microsoft Edge exception (Closed)

Created:
Sept. 24, 2018, 11:21 a.m. by geo
Modified:
Sept. 27, 2018, 11:47 a.m.
Reviewers:
Sebastian Noack, kzar
Visibility:
Public.

Description

Issue 6914 - Investigate exceptions reported by Microsoft Dashboard for Microsoft Edge

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M inject.preload.js View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 6
geo
Sept. 24, 2018, 11:23 a.m. (2018-09-24 11:23:14 UTC) #1
kzar
LGTM Nit: The commit message (title of this review) should describe the code change, rather ...
Sept. 24, 2018, 11:28 a.m. (2018-09-24 11:28:42 UTC) #2
Sebastian Noack
LGTM (but what kzar said).
Sept. 24, 2018, 12:34 p.m. (2018-09-24 12:34:06 UTC) #3
geo
Is it a bit better now?
Sept. 24, 2018, 12:45 p.m. (2018-09-24 12:45:21 UTC) #4
Sebastian Noack
On 2018/09/24 12:45:21, geo wrote: > Is it a bit better now? Yes. Want me ...
Sept. 24, 2018, 12:57 p.m. (2018-09-24 12:57:36 UTC) #5
geo
Sept. 24, 2018, 12:59 p.m. (2018-09-24 12:59:30 UTC) #6
On 2018/09/24 12:57:36, Sebastian Noack wrote:
> On 2018/09/24 12:45:21, geo wrote:
> > Is it a bit better now?
> 
> Yes. Want me to push the changes for you? Or did you regained SSH access to
the
> Mercurial server by now?

Yes, please do.

Powered by Google App Engine
This is Rietveld