Side by Side Diff: README.md
Issue 29891666:
Noissue - Enable tests to run on other browser versions (Closed)
Patch Set:
Created Sept. 25, 2018, 7:37 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
test/all.js » ('j')
|
test/all.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 Adblock Plus for Chrome, Opera, Microsoft Edge and Firefox | 1 Adblock Plus for Chrome, Opera, Microsoft Edge and Firefox |
| 2 ========================================================== | 2 ========================================================== |
| 3 | 3 |
| 4 This repository contains the platform-specific Adblock Plus source code for | 4 This repository contains the platform-specific Adblock Plus source code for |
| 5 Chrome, Opera, Microsoft Edge and Firefox. It can be used to build | 5 Chrome, Opera, Microsoft Edge and Firefox. It can be used to build |
| 6 Adblock Plus for these platforms, generic Adblock Plus code will be extracted | 6 Adblock Plus for these platforms, generic Adblock Plus code will be extracted |
| 7 from other repositories automatically (see _dependencies_ file). | 7 from other repositories automatically (see _dependencies_ file). |
| 8 | 8 |
| 9 Note that the Firefox extension built from this repository is the new | 9 Note that the Firefox extension built from this repository is the new |
| 10 [WebExtension](https://developer.mozilla.org/en-US/Add-ons/WebExtensions). | 10 [WebExtension](https://developer.mozilla.org/en-US/Add-ons/WebExtensions). |
| (...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 110 npm install | 110 npm install |
| 111 | 111 |
| 112 Start the testing process for all browsers: | 112 Start the testing process for all browsers: |
| 113 | 113 |
| 114 npm test | 114 npm test |
| 115 | 115 |
| 116 Start the testing process in one browser only: | 116 Start the testing process in one browser only: |
| 117 | 117 |
| 118 npm test -- -g <gecko/chrome> | 118 npm test -- -g <gecko/chrome> |
| 119 | 119 |
| 120 By default it downloads (and caches) the oldest compatible version | |
|
tlucas
2018/09/26 08:20:16
While at it, what do you think about defaulting to
Sebastian Noack
2018/09/26 11:00:20
Developers should still make sure everything works
| |
| 121 of each browser. In order to run the tests against a different version | |
| 122 set the CHROMIUM_BINARY or FIREFOX_BINARY environment variables. | |
| 123 Following values are accepted: | |
| 124 | |
| 125 * `installed` | |
| 126 * Uses the version installed on the system. | |
| 127 * `path:<path>` | |
| 128 * Uses the binary located at the given path. | |
| 129 * `download:<version>` | |
| 130 * Downloads the given version (for Firefox the version must be in the | |
| 131 form `<major>.<minor>`, for Chromium this must be the revision number). | |
| 132 | |
| 120 Linting | 133 Linting |
| 121 ------- | 134 ------- |
| 122 | 135 |
| 123 You can lint the code using [ESLint](http://eslint.org). | 136 You can lint the code using [ESLint](http://eslint.org). |
| 124 | 137 |
| 125 You will need to setup first. This will install our configuration | 138 You will need to setup first. This will install our configuration |
| 126 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo) | 139 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo) |
| 127 and everything needed after you run: | 140 and everything needed after you run: |
| 128 | 141 |
| 129 npm install | 142 npm install |
| 130 | 143 |
| 131 Then you can run to lint the code: | 144 Then you can run to lint the code: |
| 132 | 145 |
| 133 npm run lint | 146 npm run lint |
| OLD | NEW |
