Noissue - Enable tests to run on other browser versions

Noissue - Enable tests to run on other browser versions

[Sebastian Noack, 2018-09-25 19:54:06]

Pipeline is here (and includes both changes currently under review):
https://gitlab.com/eyeo/adblockplus/adblockpluschrome/pipelines/31184783

[tlucas, 2018-09-26 08:20:17]

https://codereview.adblockplus.org/29891666/diff/29891672/README.md
File README.md (right):

https://codereview.adblockplus.org/29891666/diff/29891672/README.md#newcode120
README.md:120: By default it downloads (and caches) the oldest compatible
version
While at it, what do you think about defaulting to "installed" when run locally
and explicitly defining the versions to be downloaded for CI in the
.gitlab-ci.yml file?

https://codereview.adblockplus.org/29891666/diff/29891672/test/all.js
File test/all.js (right):

https://codereview.adblockplus.org/29891666/diff/29891672/test/all.js#newcode36
test/all.js:36: version = spec.substr(9);
Are we ok with not checking whether someone tries to donwload a version older
then the latest compatible?

[Sebastian Noack, 2018-09-26 11:00:21]

https://codereview.adblockplus.org/29891666/diff/29891672/README.md
File README.md (right):

https://codereview.adblockplus.org/29891666/diff/29891672/README.md#newcode120
README.md:120: By default it downloads (and caches) the oldest compatible
version
On 2018/09/26 08:20:16, tlucas wrote:
> While at it, what do you think about defaulting to "installed" when run
locally
> and explicitly defining the versions to be downloaded for CI in the
> .gitlab-ci.yml file?

Developers should still make sure everything works on the oldest version, when
testing locally. I thought about running tests both on the oldest compatible
version, and the installed one (if any). But I keep this for another change.

https://codereview.adblockplus.org/29891666/diff/29891672/test/all.js
File test/all.js (right):

https://codereview.adblockplus.org/29891666/diff/29891672/test/all.js#newcode36
test/all.js:36: version = spec.substr(9);
On 2018/09/26 08:20:16, tlucas wrote:
> Are we ok with not checking whether someone tries to donwload a version older
> then the latest compatible?

I am. Since this needs to be explicitly requested, I assume people to know what
they do, and rather keep this change simple.

[tlucas, 2018-09-26 18:21:04]

On 2018/09/26 11:00:21, Sebastian Noack wrote:
> https://codereview.adblockplus.org/29891666/diff/29891672/README.md
> File README.md (right):
> 
> https://codereview.adblockplus.org/29891666/diff/29891672/README.md#newcode120
> README.md:120: By default it downloads (and caches) the oldest compatible
> version
> On 2018/09/26 08:20:16, tlucas wrote:
> > While at it, what do you think about defaulting to "installed" when run
> locally
> > and explicitly defining the versions to be downloaded for CI in the
> > .gitlab-ci.yml file?
> 
> Developers should still make sure everything works on the oldest version, when
> testing locally. I thought about running tests both on the oldest compatible
> version, and the installed one (if any). But I keep this for another change.
> 
> https://codereview.adblockplus.org/29891666/diff/29891672/test/all.js
> File test/all.js (right):
> 
>
https://codereview.adblockplus.org/29891666/diff/29891672/test/all.js#newcode36
> test/all.js:36: version = spec.substr(9);
> On 2018/09/26 08:20:16, tlucas wrote:
> > Are we ok with not checking whether someone tries to donwload a version
older
> > then the latest compatible?
> 
> I am. Since this needs to be explicitly requested, I assume people to know
what
> they do, and rather keep this change simple.

Alright - LGTM