Noissue - Enable tests to run on other browser versions

test/all.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
 const glob = require("glob");
 const path = require("path");
 const {exec} = require("child_process");
 
+function getBrowserBinary(module, browser)
+{
+  let spec = process.env[`${browser.toUpperCase()}_BINARY`];
+  let version = module.oldestCompatibleVersion;
+
+  if (spec)
+  {
+    if (spec == "installed")
+      return Promise.resolve("");
+    if (spec.startswith("path:"))
+      return Promise.resolve(spec.substr(5));
+    if (spec.startsWith("download:"))
+      version = spec.substr(9);

[tlucas, 2018/09/26 08:20:16]

Are we ok with not checking whether someone tries to donwload a version older
then the latest compatible?

[Sebastian Noack, 2018/09/26 11:00:20]

I am. Since this needs to be explicitly requested, I assume people to know what
they do, and rather keep this change simple.

+  }
+
+  return module.ensureBrowser(version);
+}
+
 for (let browser of glob.sync("./test/browsers/*.js"))
 {
   let module = require(path.resolve(browser));
 
   describe(module.platform, function()
   {
     this.timeout(0);
 
     before(function()
     {
       return Promise.all([
-        module.ensureBrowser(),
+        getBrowserBinary(module, path.basename(browser, ".js")),
         new Promise((resolve, reject) =>
         {
           exec(
             `bash -c "python build.py devenv -t ${module.platform}"`,
             (error, stdout, stderr) =>
             {
               if (error)
               {
                 console.error(stderr);
                 reject(error);
@@ skipping 28 matching lines @@
       delete require.cache[require.resolve(modulePath)];
       require(modulePath);
     }
 
     after(function()
     {
       this.driver.quit();
     });
   });
 }