Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: test/browsers/chromium.js

Issue 29891666: Noissue - Enable tests to run on other browser versions (Closed)
Patch Set: Created Sept. 25, 2018, 7:37 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict"; 18 "use strict";
19 19
20 // The Chromium version is a build number, quite obscure.
21 // Chromium 63.0.3239.x is 508578
22 // Chromium 65.0.3325.0 is 530368
23 // We currently want Chromiun 63, as we still support it and that's the
24 // loweset version that supports WebDriver.
25 const CHROMIUM_REVISION = 508578;
26
27 const webdriver = require("selenium-webdriver"); 20 const webdriver = require("selenium-webdriver");
28 const chrome = require("selenium-webdriver/chrome"); 21 const chrome = require("selenium-webdriver/chrome");
29 const {ensureChromium} = require("../../adblockpluscore/test/runners/" + 22 const {ensureChromium} = require("../../adblockpluscore/test/runners/" +
30 "chromium_download"); 23 "chromium_download");
31 24
32 exports.platform = "chrome"; 25 exports.platform = "chrome";
26 exports.ensureBrowser = ensureChromium;
33 27
34 exports.ensureBrowser = function() 28 // The Chromium version is a build number, quite obscure.
35 { 29 // Chromium 63.0.3239.x is 508578
36 return ensureChromium(CHROMIUM_REVISION); 30 // Chromium 65.0.3325.0 is 530368
37 }; 31 // We currently want Chromiun 63, as we still support it and that's the
32 // loweset version that supports WebDriver.
33 exports.oldestCompatibleVersion = 508578;
38 34
39 exports.getDriver = function(browserBinary, devenvPath) 35 exports.getDriver = function(browserBinary, devenvPath)
40 { 36 {
41 let options = new chrome.Options() 37 let options = new chrome.Options()
42 .setChromeBinaryPath(browserBinary) 38 .setChromeBinaryPath(browserBinary)
43 .addArguments("--no-sandbox") 39 .addArguments("--no-sandbox")
44 .addArguments(`load-extension=${devenvPath}`); 40 .addArguments(`load-extension=${devenvPath}`);
45 41
46 return new webdriver.Builder() 42 return new webdriver.Builder()
47 .forBrowser("chrome") 43 .forBrowser("chrome")
48 .setChromeOptions(options) 44 .setChromeOptions(options)
49 .build(); 45 .build();
50 }; 46 };
OLDNEW
« test/all.js ('K') | « test/all.js ('k') | test/browsers/firefox.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld