Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: README.md

Issue 29891666: Noissue - Enable tests to run on other browser versions (Closed)
Patch Set: Created Sept. 25, 2018, 7:37 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/all.js » ('j') | test/all.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.md
===================================================================
--- a/README.md
+++ b/README.md
@@ -117,6 +117,19 @@
npm test -- -g <gecko/chrome>
+By default it downloads (and caches) the oldest compatible version
tlucas 2018/09/26 08:20:16 While at it, what do you think about defaulting to
Sebastian Noack 2018/09/26 11:00:20 Developers should still make sure everything works
+of each browser. In order to run the tests against a different version
+set the CHROMIUM_BINARY or FIREFOX_BINARY environment variables.
+Following values are accepted:
+
+* `installed`
+ * Uses the version installed on the system.
+* `path:<path>`
+ * Uses the binary located at the given path.
+* `download:<version>`
+ * Downloads the given version (for Firefox the version must be in the
+ form `<major>.<minor>`, for Chromium this must be the revision number).
+
Linting
-------
« no previous file with comments | « no previous file | test/all.js » ('j') | test/all.js » ('J')

Powered by Google App Engine
This is Rietveld