Issue 29891677: Noissue - Make subscribe link tests more reliable by waiting for options page to be ready

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29891677: Noissue - Make subscribe link tests more reliable by waiting for options page to be ready (Closed)

Created:
Sept. 25, 2018, 7:46 p.m. by Sebastian Noack

Modified:
Sept. 26, 2018, 6:33 p.m.

Reviewers:
tlucas, hub

Visibility:
Public.

Description

Noissue - Make subscribe link tests more reliable by waiting for options page to be ready

Patch Set 2 : Increased timeout for options page tab as requested by Ross #

Created: Sept. 26, 2018, 11:06 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	test/wrappers/pages.js	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Sebastian Noack

Pipeline is here (and includes both changes currently under review): https://gitlab.com/eyeo/adblockplus/adblockpluschrome/pipelines/31184783

Sept. 25, 2018, 7:53 p.m. (2018-09-25 19:53:19 UTC) #1

tlucas

https://codereview.adblockplus.org/29891677/diff/29891678/test/wrappers/pages.js File test/wrappers/pages.js (right): https://codereview.adblockplus.org/29891677/diff/29891678/test/wrappers/pages.js#newcode61 test/wrappers/pages.js:61: driver.wait(until.ableToSwitchToFrame(0), 1000).then(() => In order to not reject subscriptions, ...

Sept. 26, 2018, 8:28 a.m. (2018-09-26 08:28:17 UTC) #3

Sebastian Noack

Sept. 26, 2018, 11:07 a.m. (2018-09-26 11:07:36 UTC) #4

tlucas

Sept. 26, 2018, 6:19 p.m. (2018-09-26 18:19:41 UTC) #5

LGTM

https://codereview.adblockplus.org/29891677/diff/29891678/test/wrappers/pages.js
File test/wrappers/pages.js (right):

https://codereview.adblockplus.org/29891677/diff/29891678/test/wrappers/pages...
test/wrappers/pages.js:61: driver.wait(until.ableToSwitchToFrame(0),
1000).then(() =>
On 2018/09/26 11:07:36, Sebastian Noack wrote:
> On 2018/09/26 08:28:17, tlucas wrote:
> > In order to not reject subscriptions, which might take longer (in case that
> > could happen), "wait()" should be called without a timeout IMHO.
> > Same below.
> 
> But if there is a bug (caught by this test) with the subscription links, then
> the tests would never complete rather than failing.

Acknowledged.

Expand All Messages | Collapse All Messages