Noissue - Make subscribe link tests more reliable by waiting for options page to be ready

test/wrappers/pages.js

Index: test/wrappers/pages.js
===================================================================
--- a/test/wrappers/pages.js
+++ b/test/wrappers/pages.js
@@ -21,7 +21,7 @@
 
 const assert = require("assert");
 const Jimp = require("jimp");
-const {By} = require("selenium-webdriver");
+const {By, until} = require("selenium-webdriver");
 
 // Once we require Node.js >= 10 this should be replaced with
 // the built-in finally() method of the Promise object.
@@ -58,8 +58,9 @@
     )
   ).then(handles =>
     closeWindow(driver, handles[2], handles[1], () =>
-      driver.switchTo().frame(0).then(() =>
-        driver.findElement(By.id("dialog-content-predefined"))
+      driver.wait(until.ableToSwitchToFrame(0), 1000).then(() =>

[tlucas, 2018/09/26 08:28:17]

In order to not reject subscriptions, which might take longer (in case that
could happen), "wait()" should be called without a timeout IMHO.
Same below.

[Sebastian Noack, 2018/09/26 11:07:36]

But if there is a bug (caught by this test) with the subscription links, then
the tests would never complete rather than failing.

[tlucas, 2018/09/26 18:19:40]

Acknowledged.

+        driver.wait(until.elementLocated(By.id("dialog-content-predefined")),
+                    1000)
       ).then(dialog =>
         Promise.all([
           dialog.isDisplayed(),