Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(435)

Issue 29891680: Issue 6986 - Fix tests runtime on Windows

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 3 days ago by hub
Modified:
2 weeks, 4 days ago
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

- fs.chmodSync expects an integer for the mode - don't run Chrome headless.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Donc run headless on Windows #

Total comments: 2

Patch Set 3 : Fixed nit #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M test/runners/chromium_process.js View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M test/runners/chromium_remote_process.js View 1 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 13
hub
3 weeks, 3 days ago (2018-09-25 21:59:59 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29891680/diff/29891681/test/runners/chromium_remote_process.js File test/runners/chromium_remote_process.js (right): https://codereview.adblockplus.org/29891680/diff/29891681/test/runners/chromium_remote_process.js#newcode62 test/runners/chromium_remote_process.js:62: fs.chmodSync(chromiumPath, 0o700); fs.constants.S_IRWXU is 0o700. This change has no ...
3 weeks, 3 days ago (2018-09-25 22:12:47 UTC) #2
hub
https://codereview.adblockplus.org/29891680/diff/29891681/test/runners/chromium_remote_process.js File test/runners/chromium_remote_process.js (right): https://codereview.adblockplus.org/29891680/diff/29891681/test/runners/chromium_remote_process.js#newcode62 test/runners/chromium_remote_process.js:62: fs.chmodSync(chromiumPath, 0o700); On 2018/09/25 22:12:46, Sebastian Noack wrote: > ...
3 weeks, 2 days ago (2018-09-26 01:03:25 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29891680/diff/29891681/test/runners/chromium_remote_process.js File test/runners/chromium_remote_process.js (right): https://codereview.adblockplus.org/29891680/diff/29891681/test/runners/chromium_remote_process.js#newcode62 test/runners/chromium_remote_process.js:62: fs.chmodSync(chromiumPath, 0o700); On 2018/09/26 01:03:25, hub wrote: > On ...
3 weeks, 2 days ago (2018-09-26 01:10:51 UTC) #4
geo
https://codereview.adblockplus.org/29891680/diff/29891681/test/runners/chromium_remote_process.js File test/runners/chromium_remote_process.js (right): https://codereview.adblockplus.org/29891680/diff/29891681/test/runners/chromium_remote_process.js#newcode62 test/runners/chromium_remote_process.js:62: fs.chmodSync(chromiumPath, 0o700); On 2018/09/26 01:10:51, Sebastian Noack wrote: > ...
3 weeks, 2 days ago (2018-09-26 13:34:09 UTC) #5
geo
I've tested the patch in combination with this fix:https://hg.adblockplus.org/adblockpluscore/rev/50ac4b73ce21 Now I'm getting the following error: ...
3 weeks, 2 days ago (2018-09-26 22:00:09 UTC) #6
hub
On 2018/09/26 22:00:09, geo wrote: > I've tested the patch in combination with this > ...
3 weeks, 1 day ago (2018-09-27 12:47:05 UTC) #7
Sebastian Noack
FWIW, in adblockpluschrome the browser tests pass on Windows now. We use the exact same ...
3 weeks, 1 day ago (2018-09-27 15:53:25 UTC) #8
hub
On 2018/09/27 15:53:25, Sebastian Noack wrote: > FWIW, in adblockpluschrome the browser tests pass on ...
3 weeks, 1 day ago (2018-09-27 16:52:39 UTC) #9
hub
I have updated the patch to disable headless on Chrome on Windows.
3 weeks, 1 day ago (2018-09-27 17:01:02 UTC) #10
Sebastian Noack
Geo, can you try if the tests pass on Windows after applying the latest patch ...
3 weeks ago (2018-09-28 15:37:00 UTC) #11
hub
Updated patch https://codereview.adblockplus.org/29891680/diff/29893612/test/runners/chromium_process.js File test/runners/chromium_process.js (right): https://codereview.adblockplus.org/29891680/diff/29893612/test/runners/chromium_process.js#newcode36 test/runners/chromium_process.js:36: let {platform} = process; On 2018/09/28 15:37:00, ...
3 weeks ago (2018-09-28 15:56:35 UTC) #12
geo
2 weeks, 4 days ago (2018-10-01 13:19:04 UTC) #13
https://codereview.adblockplus.org/29891680/diff/29894590/test/runners/chromi...
File test/runners/chromium_remote_process.js (right):

https://codereview.adblockplus.org/29891680/diff/29894590/test/runners/chromi...
test/runners/chromium_remote_process.js:72: "--headless", "--single-process",
"--disable-gpu", "--no-sandbox",
I've tested the latest patch, but I'm still getting that `--single-process is
not supported in chrome multiple dll browser` error.

I removed the "--single-process" argument (just to see what happens) and now I
have a different error,

`
Browser unit test failed: EvalError: Refused to evaluate a string as JavaScript
because 'unsafe-eval' is not an allowed source of script in the following
Content Security Policy directive: "script-src 'self' blob: filesystem:
chrome-extension-resource:".


    at Object.<anonymous> (bundle.js:71:1)
    at __webpack_require__ (bundle.js:20:30)
    at bundle.js:63:18
    at bundle.js:66:10
`
I'm not sure if that was a step in the right direction or not, as I'm really new
to this whole thing, however if you need me to test anything else (even before
uploading a new patch), let me know, I'm more than happy to assist.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5