Unified Diff: test/runners/chromium_process.js
Issue 29891680:
Issue 6986 - Don't use chromium remote interface on Windows (Closed)
Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Fixed nit
Created Sept. 28, 2018, 3:56 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
test/runners/chromium_remote_process.js » ('j')
|
test/runners/chromium_remote_process.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test/runners/chromium_process.js |
| =================================================================== |
| --- a/test/runners/chromium_process.js |
| +++ b/test/runners/chromium_process.js |
| @@ -29,21 +29,23 @@ |
| // Chromium 65.0.3325.0 is 530368 |
| // We currently want Chromiun 63, as we still support it and that's the |
| // loweset version that supports WebDriver. |
| const CHROMIUM_REVISION = 508578; |
| function runScript(chromiumPath, script, scriptName, scriptArgs) |
| { |
| const options = new chrome.Options() |
| - .headless() |
| // Disabling sandboxing is needed on some system configurations |
| // like Debian 9. |
| .addArguments("--no-sandbox") |
| .setChromeBinaryPath(chromiumPath); |
| + // Headless doesn't seem to work on Windows. |
| + if (process.platform != "win32") |
| + options.headless(); |
| const driver = new Builder() |
| .forBrowser("chrome") |
| .setChromeOptions(options) |
| .build(); |
| return executeScript(driver, "Chromium (WebDriver)", |
| script, scriptName, scriptArgs); |
« no previous file with comments
|
« no previous file
|
test/runners/chromium_remote_process.js » ('j')
|
test/runners/chromium_remote_process.js » ('J')
