Unified Diff: test/runners/chromium_remote_process.js
Issue 29891680:
Issue 6986 - Don't use chromium remote interface on Windows (Closed)
Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Fixed nit
Created Sept. 28, 2018, 3:56 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« test/runners/chromium_process.js ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test/runners/chromium_remote_process.js |
| =================================================================== |
| --- a/test/runners/chromium_remote_process.js |
| +++ b/test/runners/chromium_remote_process.js |
| @@ -54,17 +54,18 @@ |
| catch (error) |
| { |
| console.error(error); |
| } |
| } |
| function startChromium(chromiumPath) |
| { |
| - fs.chmodSync(chromiumPath, fs.constants.S_IRWXU); |
| + // fs.constants.S_IRWXU is undefined on Windows, so we use a numerical const. |
| + fs.chmodSync(chromiumPath, 0o700); |
| let dataDir = fs.mkdtempSync(path.join(os.tmpdir(), "chromium-data")); |
| let child = null; |
| return { |
| kill: () => child && child.kill(), |
| done: new Promise((resolve, reject) => |
| { |
| child = childProcess.execFile(chromiumPath, [ |
« no previous file with comments
|
« test/runners/chromium_process.js ('k')
|
no next file »
|
no next file with comments »
