Issue 6989 - Optimize CSS rule generation

[Manish Jethani, 2018-09-26 15:29:56]

https://codereview.adblockplus.org/29892563/diff/29892564/lib/elemHide.js
File lib/elemHide.js (right):

https://codereview.adblockplus.org/29892563/diff/29892564/lib/elemHide.js#new...
lib/elemHide.js:288: for (let i = 0; i < selectors.length - 1; i++)
I tried a few things here:

 1.  Used `for...of` and sliced out the ", " at the end before appending "
{display: none !important;}\n"
 2.  Used `selectors.pop()`, a `for...of` loop, and concatenated the last
element in the array at the end
 3.  Used a regular `for` loop until the second to last entry, then concatenated
the last entry at the end

The last one (which is in the current patch) performs the best.

[Manish Jethani, 2018-09-26 15:30:28]

Patch Set 1

See issue description and inline comments here.

On 2018/09/26 15:29:56, Manish Jethani wrote:
> https://codereview.adblockplus.org/29892563/diff/29892564/lib/elemHide.js
> File lib/elemHide.js (right):
> 
>
https://codereview.adblockplus.org/29892563/diff/29892564/lib/elemHide.js#new...
> lib/elemHide.js:288: for (let i = 0; i < selectors.length - 1; i++)
> I tried a few things here:
> 
>  1.  Used `for...of` and sliced out the ", " at the end before appending "
> {display: none !important;}\n"
>  2.  Used `selectors.pop()`, a `for...of` loop, and concatenated the last
> element in the array at the end
>  3.  Used a regular `for` loop until the second to last entry, then
concatenated
> the last entry at the end
> 
> The last one (which is in the current patch) performs the best.

[hub, 2018-09-26 16:49:11]

LGTM

https://codereview.adblockplus.org/29892563/diff/29892564/lib/elemHide.js
File lib/elemHide.js (right):

https://codereview.adblockplus.org/29892563/diff/29892564/lib/elemHide.js#new...
lib/elemHide.js:288: for (let i = 0; i < selectors.length - 1; i++)
On 2018/09/26 15:29:56, Manish Jethani wrote:
> I tried a few things here:
> 
>  1.  Used `for...of` and sliced out the ", " at the end before appending "
> {display: none !important;}\n"
>  2.  Used `selectors.pop()`, a `for...of` loop, and concatenated the last
> element in the array at the end
>  3.  Used a regular `for` loop until the second to last entry, then
concatenated
> the last entry at the end
> 
> The last one (which is in the current patch) performs the best.

Acknowledged.