Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29892576: Noissue - Fix Firefox executable path for Windows (Closed)

Created:
Sept. 26, 2018, 7:44 p.m. by geo
Modified:
Sept. 27, 2018, 11:51 a.m.
CC:
hub
Visibility:
Public.

Description

Noissue - Fix Firefox executable path for Windows

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/runners/firefox_download.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
geo
This fix is related to https://issues.adblockplus.org/ticket/6985 https://issues.adblockplus.org/ticket/6986
Sept. 26, 2018, 7:57 p.m. (2018-09-26 19:57:55 UTC) #1
Sebastian Noack
LGTM @Manish, Hubert: If we happen to have another dependency update for adblockpluscore, it would ...
Sept. 26, 2018, 8:08 p.m. (2018-09-26 20:08:08 UTC) #2
tlucas
LGTM
Sept. 27, 2018, 9:06 a.m. (2018-09-27 09:06:18 UTC) #3
Manish Jethani
Sept. 27, 2018, 11:27 a.m. (2018-09-27 11:27:21 UTC) #4
On 2018/09/26 20:08:08, Sebastian Noack wrote:
> LGTM
> 
> @Manish, Hubert: If we happen to have another dependency update for
> adblockpluscore, it would be great to get this fix in as well. It has no
effect
> on the builds, but would help us moving forward with fixing the test
automation
> in adblockpluschrome on Windows.

Acknowledged.

Powered by Google App Engine
This is Rietveld