Noissue - Avoid string replacement for domains with no trailing dots

lib/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 530 matching lines @@
 
     // If no domains are set the rule matches everywhere
     if (!domains)
       return true;
 
     // If the document has no host name, match only if the filter
     // isn't restricted to specific domains
     if (!docDomain)
       return domains.get("");
 
-    docDomain = docDomain.replace(/\.+$/, "").toLowerCase();
+    if (docDomain[docDomain.length - 1] == ".")
+      docDomain = docDomain.replace(/\.+$/, "");
+
+    docDomain = docDomain.toLowerCase();
 
     while (true)
     {
       let isDomainIncluded = domains.get(docDomain);
       if (typeof isDomainIncluded != "undefined")
         return isDomainIncluded;
 
       let nextDot = docDomain.indexOf(".");
       if (nextDot < 0)
         break;
       docDomain = docDomain.substr(nextDot + 1);
     }
     return domains.get("");
   },
 
   /**
    * Checks whether this filter is active only on a domain and its subdomains.
    * @param {string} docDomain
    * @return {boolean}
    */
   isActiveOnlyOnDomain(docDomain)
   {
     let {domains} = this;
 
     if (!docDomain || !domains || domains.get(""))
       return false;
 
-    docDomain = docDomain.replace(/\.+$/, "").toLowerCase();
+    if (docDomain[docDomain.length - 1] == ".")
+      docDomain = docDomain.replace(/\.+$/, "");
+
+    docDomain = docDomain.toLowerCase();
 
     for (let [domain, isIncluded] of domains)
     {
       if (isIncluded && domain != docDomain)
       {
         if (domain.length <= docDomain.length)
           return false;
 
         if (!domain.endsWith("." + docDomain))
           return false;
@@ skipping 641 matching lines @@
 
   /**
    * Script that should be executed
    * @type {string}
    */
   get script()
   {
     return this.body;
   }
 });