Noissue - Avoid string replacement for domains with no trailing dots

[Manish Jethani, 2018-09-26 22:58:15]

Patch Set 1

Try this:

(function()
{ 
  let array = []; 
  for (let i = 0; i < 10000000; i++)
  { 
    let domain = Math.random().toString(36).substring(2);
    if (Math.random() < .001)
      domain += ".";
    array.push(domain);
  }
  
  let start = Date.now();
  
  for (let i = 0; i < array.length; i++)
  { 
    //if (array[i][array[i].length - 1] == ".")
      array[i] = array[i].replace(/\.+$/, "");
  }
  
  console.log(Date.now() - start);
})();

Then uncomment the commented out line and try it again.

In this example, 1/1,000 domains contain a trailing dot. In practice the number
is zero.

If you increase 0.001 to something like 0.9 (9/10 domains), you'll see that the
performance is the same whether or not we do the check; but if the value is at
0.001 (1/1,000), it makes a big difference to the performance if we check for at
least one trailing dot first.

On my machine here I'm seeing a 3x speed-up.

[hub, 2018-09-27 18:50:56]

nice catch

LGTM