Issue 29892596: Issue 6992 - Remove keyword-by-filter map

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29892596: Issue 6992 - Remove keyword-by-filter map (Closed)

Created:
Sept. 27, 2018, 4:23 a.m. by Manish Jethani

Modified:
Oct. 2, 2018, 5:01 p.m.

Reviewers:
sergei, hub, Jon Sonesen

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Created: Sept. 28, 2018, 9:22 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -116 lines)			Patch
M	lib/filterClasses.js	View		2 chunks	+10 lines, -10 lines	0 comments	Download
M	lib/matcher.js	View	1 2	2 chunks	+55 lines, -102 lines	0 comments	Download
M	test/filterListener.js	View		1 chunk	+3 lines, -4 lines	0 comments	Download

Total messages: 10

Manish Jethani

Patch Set 1 See ticket: https://issues.adblockplus.org/ticket/6992

Sept. 27, 2018, 4:41 a.m. (2018-09-27 04:41:35 UTC) #3

Manish Jethani

Patch Set 2: Keep isSlowFilter UI needs this function, but the updated implementation performs worse ...

Sept. 27, 2018, 11:24 a.m. (2018-09-27 11:24:53 UTC) #4

Manish Jethani

Patch Set 3: Implement faster version of isSlowFilter

Sept. 28, 2018, 9:23 a.m. (2018-09-28 09:23:00 UTC) #5

Jon Sonesen

Just an update I have been reading over this and testing it looks mostly good ...

Oct. 1, 2018, 3:20 p.m. (2018-10-01 15:20:23 UTC) #6

Jon Sonesen

So, yeah LGTM sergei, or hub may want to also take a peek since I ...

Oct. 2, 2018, 4:40 p.m. (2018-10-02 16:40:42 UTC) #7

Manish Jethani

On 2018/10/02 16:40:42, Jon Sonesen wrote: > So, yeah LGTM sergei, or hub may want ...

Oct. 2, 2018, 4:54 p.m. (2018-10-02 16:54:04 UTC) #9

Manish Jethani

Oct. 2, 2018, 4:55 p.m. (2018-10-02 16:55:32 UTC) #10

On 2018/10/02 16:49:49, hub wrote:
> LGTM

Thanks, I'll go ahead and land this then.