Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29897571: Issue 6996 - Fix -c option (Closed)

Created:
Oct. 1, 2018, 3:30 p.m. by Vasily Kuznetsov
Modified:
Oct. 5, 2018, 11:05 a.m.
CC:
tlucas
Base URL:
https://hg.adblockplus.org/codingtools
Visibility:
Public.

Description

Issue 6996 - Fix -c option Repository: https://hg.adblockplus.org/codingtools Base revision: a4d31ca88c6e

Patch Set 1 #

Total comments: 3

Patch Set 2 : Accept various types of revision ids #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M hgreview.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6
Vasily Kuznetsov
Hi Jon, Here's a fix for your ticket with an awesome number ;) Tristan, Sebastian, ...
Oct. 1, 2018, 3:39 p.m. (2018-10-01 15:39:39 UTC) #1
hub
https://codereview.adblockplus.org/29897571/diff/29897572/hgreview.py File hgreview.py (right): https://codereview.adblockplus.org/29897571/diff/29897572/hgreview.py#newcode58 hgreview.py:58: raise error.Abort('Argument of --change must be an integer') I'm ...
Oct. 1, 2018, 4:06 p.m. (2018-10-01 16:06:14 UTC) #2
Vasily Kuznetsov
https://codereview.adblockplus.org/29897571/diff/29897572/hgreview.py File hgreview.py (right): https://codereview.adblockplus.org/29897571/diff/29897572/hgreview.py#newcode58 hgreview.py:58: raise error.Abort('Argument of --change must be an integer') On ...
Oct. 1, 2018, 4:32 p.m. (2018-10-01 16:32:52 UTC) #3
Vasily Kuznetsov
Hi Hub, Check out the new patchset, this should work with all kinds of revision ...
Oct. 2, 2018, 10:06 a.m. (2018-10-02 10:06:44 UTC) #4
Vasily Kuznetsov
Hi guys, Can someone check if this patch fixes the issue for them (it does ...
Oct. 5, 2018, 11:02 a.m. (2018-10-05 11:02:58 UTC) #5
Sebastian Noack
Oct. 5, 2018, 11:04 a.m. (2018-10-05 11:04:25 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld