Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29898563: Issue 7012 - Update adblockpluscore dependency to revision hg:1c81010449da git:d9555ca (Closed)

Created:
Oct. 2, 2018, 1:41 p.m. by hub
Modified:
Oct. 2, 2018, 3:14 p.m.
Reviewers:
Sebastian Noack, kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 7012 - Update adblockpluscore dependency to revision hg:1c81010449da git:d9555ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M dependencies View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
hub
Oct. 2, 2018, 1:41 p.m. (2018-10-02 13:41:41 UTC) #1
hub
this is to get into master for 3.4. I was told Sebastian had agreed to ...
Oct. 2, 2018, 1:43 p.m. (2018-10-02 13:43:50 UTC) #2
Sebastian Noack
Oct. 2, 2018, 2:04 p.m. (2018-10-02 14:04:08 UTC) #3
LGTM (for master).

For reference, this dependency update merely adds a new default subscription to
subscription.xml. Arthur asked me to get this still in 3.4, I didn't object
since no code is touched in this change, hence the risk is neglectable.

Powered by Google App Engine
This is Rietveld