Issue 29898563: Issue 7012 - Update adblockpluscore dependency to revision hg:1c81010449da git:d9555ca

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29898563: Issue 7012 - Update adblockpluscore dependency to revision hg:1c81010449da git:d9555ca (Closed)

Created:
Oct. 2, 2018, 1:41 p.m. by hub

Modified:
Oct. 2, 2018, 3:14 p.m.

Reviewers:
Sebastian Noack, kzar

Base URL:
https://hg.adblockplus.org/adblockpluschrome/

Visibility:
Public.

Description

Issue 7012 - Update adblockpluscore dependency to revision hg:1c81010449da git:d9555ca

Patch Set 1 #

Created: Oct. 2, 2018, 1:41 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	dependencies	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hub

this is to get into master for 3.4. I was told Sebastian had agreed to ...

Oct. 2, 2018, 1:43 p.m. (2018-10-02 13:43:50 UTC) #2

Sebastian Noack

Oct. 2, 2018, 2:04 p.m. (2018-10-02 14:04:08 UTC) #3

LGTM (for master).

For reference, this dependency update merely adds a new default subscription to
subscription.xml. Arthur asked me to get this still in 3.4, I didn't object
since no code is touched in this change, hence the risk is neglectable.

Expand All Messages | Collapse All Messages