Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(299)

Issue 29899601: Issue 7015 - Serialize subscriptions for *exportData in one loop

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 2 days ago by Jon Sonesen
Modified:
2 weeks, 1 day ago
CC:
kzar
Visibility:
Public.

Description

Issue 7015 - Serialize subscriptions for *exportData in one loop

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -18 lines) Patch
M lib/filterStorage.js View 1 1 chunk +13 lines, -18 lines 0 comments Download

Messages

Total messages: 8
Jon Sonesen
2 weeks, 2 days ago (2018-10-03 15:53:18 UTC) #1
Jon Sonesen
Here is this for now, not sure in which order 7016 and this patch should ...
2 weeks, 2 days ago (2018-10-03 15:55:13 UTC) #2
Manish Jethani
On 2018/10/03 15:55:13, Jon Sonesen wrote: > Here is this for now, not sure in ...
2 weeks, 2 days ago (2018-10-03 16:06:52 UTC) #3
Manish Jethani
On 2018/10/03 16:06:52, Manish Jethani wrote: > On 2018/10/03 15:55:13, Jon Sonesen wrote: > > ...
2 weeks, 2 days ago (2018-10-03 16:09:43 UTC) #4
Manish Jethani
On 2018/10/03 15:55:13, Jon Sonesen wrote: > Here is this for now, not sure in ...
2 weeks, 2 days ago (2018-10-03 16:12:29 UTC) #5
Jon Sonesen
No problem, that's why I have cc'd folks. Working 7016 now.
2 weeks, 2 days ago (2018-10-03 16:27:28 UTC) #6
Sebastian Noack
https://codereview.adblockplus.org/29899601/diff/29899602/lib/filterStorage.js File lib/filterStorage.js (right): https://codereview.adblockplus.org/29899601/diff/29899602/lib/filterStorage.js#newcode471 lib/filterStorage.js:471: buf.splice(0); While optimizing this code, you might want consider ...
2 weeks, 2 days ago (2018-10-03 16:33:25 UTC) #7
Jon Sonesen
2 weeks, 1 day ago (2018-10-04 00:26:08 UTC) #8
On 2018/10/03 16:33:25, Sebastian Noack wrote:
> https://codereview.adblockplus.org/29899601/diff/29899602/lib/filterStorage.js
> File lib/filterStorage.js (right):
> 
>
https://codereview.adblockplus.org/29899601/diff/29899602/lib/filterStorage.j...
> lib/filterStorage.js:471: buf.splice(0);
> While optimizing this code, you might want consider using `buf = []` which is
> used to be much faster than splice(). I didn't benchmark it recently though,
so
> you might want to double check on recent browser versions.

Yeah, I think that would be great. Although, depending on #7016 the buf literal
may go away.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5