Issue 7015 - Serialize subscriptions for *exportData in one loop

Issue 7015 - Serialize subscriptions for *exportData in one loop

[Jon Sonesen, 2018-10-03 15:55:13]

Here is this for now, not sure in which order 7016 and this patch should land
but it seems to me they can be reviewed at the same time so it doesn't matter
too much.

[Manish Jethani, 2018-10-03 16:06:52]

On 2018/10/03 15:55:13, Jon Sonesen wrote:
> Here is this for now, not sure in which order 7016 and this patch should land
> but it seems to me they can be reviewed at the same time so it doesn't matter
> too much.

Yes, I don't think the order matters here, they can be done independently.

[Manish Jethani, 2018-10-03 16:09:43]

On 2018/10/03 16:06:52, Manish Jethani wrote:
> On 2018/10/03 15:55:13, Jon Sonesen wrote:
> > Here is this for now, not sure in which order 7016 and this patch should
land
> > but it seems to me they can be reviewed at the same time so it doesn't
matter
> > too much.
> 
> Yes, I don't think the order matters here, they can be done independently.

Can you rebase this on next now? I landed a patch that introduces a conflict.

[Manish Jethani, 2018-10-03 16:12:29]

On 2018/10/03 15:55:13, Jon Sonesen wrote:
> Here is this for now, not sure in which order 7016 and this patch should land
> but it seems to me they can be reviewed at the same time so it doesn't matter
> too much.

I've removed the ready flag from #7015. Let's do the patch already, but let's
not land it because we need to get inputs from others about whether this is OK
to do or not.

We can land the patch for #7016 first and then later rebase this one.

[Jon Sonesen, 2018-10-03 16:27:28]

No problem, that's why I have cc'd folks. Working 7016 now.

[Sebastian Noack, 2018-10-03 16:33:25]

https://codereview.adblockplus.org/29899601/diff/29899602/lib/filterStorage.js
File lib/filterStorage.js (right):

https://codereview.adblockplus.org/29899601/diff/29899602/lib/filterStorage.j...
lib/filterStorage.js:471: buf.splice(0);
While optimizing this code, you might want consider using `buf = []` which is
used to be much faster than splice(). I didn't benchmark it recently though, so
you might want to double check on recent browser versions.

[Jon Sonesen, 2018-10-04 00:26:08]

On 2018/10/03 16:33:25, Sebastian Noack wrote:
> https://codereview.adblockplus.org/29899601/diff/29899602/lib/filterStorage.js
> File lib/filterStorage.js (right):
> 
>
https://codereview.adblockplus.org/29899601/diff/29899602/lib/filterStorage.j...
> lib/filterStorage.js:471: buf.splice(0);
> While optimizing this code, you might want consider using `buf = []` which is
> used to be much faster than splice(). I didn't benchmark it recently though,
so
> you might want to double check on recent browser versions.

Yeah, I think that would be great. Although, depending on #7016 the buf literal
may go away.

[Manish Jethani, 2018-10-24 21:38:35]

This would need a rebase.

[Jon Sonesen, 2018-10-24 21:42:13]

Indeed, I am on it right now

[Manish Jethani, 2019-01-15 14:25:20]

Now that this has been moved to GitLab [1], can we close this?

[1]: https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/14

[Jon Sonesen, 2019-01-28 20:16:43]

On 2019/01/15 14:25:20, Manish Jethani wrote:
> Now that this has been moved to GitLab [1], can we close this?
> 
> [1]: https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/14

Sorry for the delay! Done.