Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(396)

Issue 29901591: Issue 7020 - publish gecko with Node.js (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 1 day ago by tlucas
Modified:
2 days, 17 hours ago
Reviewers:
kzar, Sebastian Noack
Base URL:
https://gitlab.com/eyeo/adblockplus/adblockpluschrome/tree/6323e74d580026e3bd1e8e631fcddaf0bbaa34df
Visibility:
Public.

Description

Issue 7020 - publish gecko with Node.js

Patch Set 1 #

Total comments: 17

Patch Set 2 : #

Total comments: 10

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -18 lines) Patch
A + automation/.eslintrc.json View 1 1 chunk +1 line, -1 line 0 comments Download
A + automation/publish.js View 1 1 chunk +22 lines, -14 lines 0 comments Download
A automation/target/gecko.js View 1 2 1 chunk +94 lines, -0 lines 0 comments Download
M package.json View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8
tlucas
https://codereview.adblockplus.org/29901591/diff/29901592/automation/build.js File automation/build.js (left): https://codereview.adblockplus.org/29901591/diff/29901592/automation/build.js#oldcode1 automation/build.js:1: /* For some reason, rietveld recognized this as a ...
2 weeks, 1 day ago (2018-10-04 15:27:08 UTC) #1
Sebastian Noack
I'd like to suggest a different file structure: build/publish.js build/target/gecko.js Also it seems almost all ...
2 weeks, 1 day ago (2018-10-04 19:56:53 UTC) #2
tlucas
Patch Set 2: * Rename Issue * Adding top-level argument parsing. * Use parsed arguments, ...
4 days, 13 hours ago (2018-10-15 10:26:21 UTC) #3
kzar
https://codereview.adblockplus.org/29901591/diff/29911573/automation/publish.js File automation/publish.js (right): https://codereview.adblockplus.org/29901591/diff/29911573/automation/publish.js#newcode44 automation/publish.js:44: platforms[args.platform_name].run(args); I guess if the platform doesn't exist we'll ...
4 days, 11 hours ago (2018-10-15 12:42:58 UTC) #4
tlucas
https://codereview.adblockplus.org/29901591/diff/29911573/automation/publish.js File automation/publish.js (right): https://codereview.adblockplus.org/29901591/diff/29911573/automation/publish.js#newcode44 automation/publish.js:44: platforms[args.platform_name].run(args); On 2018/10/15 12:42:58, kzar wrote: > I guess ...
4 days, 10 hours ago (2018-10-15 14:12:39 UTC) #5
kzar
https://codereview.adblockplus.org/29901591/diff/29911573/automation/publish.js File automation/publish.js (right): https://codereview.adblockplus.org/29901591/diff/29911573/automation/publish.js#newcode44 automation/publish.js:44: platforms[args.platform_name].run(args); On 2018/10/15 14:12:39, tlucas wrote: > On 2018/10/15 ...
4 days, 9 hours ago (2018-10-15 14:46:10 UTC) #6
tlucas
Patch Set 3 * Adding a comment about signAddon's logging behaviour https://codereview.adblockplus.org/29901591/diff/29911573/automation/target/gecko.js File automation/target/gecko.js (right): ...
3 days, 15 hours ago (2018-10-16 08:42:40 UTC) #7
kzar
3 days, 13 hours ago (2018-10-16 10:42:30 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5