Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29905561: Noissue - build before testing (Closed)

Created:
Oct. 9, 2018, 12:34 p.m. by tlucas
Modified:
Oct. 9, 2018, 12:42 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Noissue - build before testing

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M .gitlab-ci.yml View 3 chunks +20 lines, -20 lines 1 comment Download

Messages

Total messages: 2
tlucas
Pipeline: https://gitlab.com/triluc/adblockpluschrome/pipelines/32406549 https://codereview.adblockplus.org/29905561/diff/29905562/.gitlab-ci.yml File .gitlab-ci.yml (right): https://codereview.adblockplus.org/29905561/diff/29905562/.gitlab-ci.yml#newcode81 .gitlab-ci.yml:81: Moving these lines is not necessary, but ...
Oct. 9, 2018, 12:36 p.m. (2018-10-09 12:36:58 UTC) #1
Sebastian Noack
Oct. 9, 2018, 12:38 p.m. (2018-10-09 12:38:31 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld