Issue 7027 - User FilterStorage.knownSubscriptions in messageResponder.js

Issue TBD - User FilterStorage.knownSubscriptions in messageResponder.js

[Jon Sonesen, 2018-10-12 05:02:35]

This is what I came up with while trying to test my changes in core. I know you
had assigned it to yourself, but since this was done in the process I thought I
would upload it. If you would rather do it yourself or have me switch to gitlab
for the change I am happy to.

[Thomas Greiner, 2018-10-12 08:14:42]

Thanks for sharing. We do accept reviews through Rietveld and tickets through
Trac so no need to use GitLab if you prefer it this way.

In this particular case I'm pretty much done with the change and, while at it,
also rewrote the code a little bit to avoid the array conversion and multiple
loops (see
https://gitlab.com/ThomasGreiner/adblockplusui/commit/a950df95af6b923c2e9fcd5...).
I only need to get the review started.

That being said, I noticed that you're using
`FilterStorage.knownSubscriptions.values()` instead of
`FilterStorage.subscriptions()` so I was wondering whether there is a reason to
use one over the other.

[Jon Sonesen, 2018-10-12 10:25:09]

On 2018/10/12 08:14:42, Thomas Greiner wrote:
> Thanks for sharing. We do accept reviews through Rietveld and tickets through
> Trac so no need to use GitLab if you prefer it this way.
> 
> In this particular case I'm pretty much done with the change and, while at it,
> also rewrote the code a little bit to avoid the array conversion and multiple
> loops (see
>
https://gitlab.com/ThomasGreiner/adblockplusui/commit/a950df95af6b923c2e9fcd5...).
> I only need to get the review started.
> 
> That being said, I noticed that you're using
> `FilterStorage.knownSubscriptions.values()` instead of
> `FilterStorage.subscriptions()` so I was wondering whether there is a reason
to
> use one over the other.

subscriptions is a generator based on know subscriptions. It actually is better
to use subscriptions. I like you patch much better I'll close this :)