Issue 29913558: Issue 7057 - [CMS] Build failing for `urllib3`

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29913558: Issue 7057 - [CMS] Build failing for `urllib3` (Closed)

Created:
Oct. 17, 2018, 12:09 p.m. by Tudor Avram

Modified:
Oct. 17, 2018, 2:47 p.m.

Reviewers:
Vasily Kuznetsov

Visibility:
Public.

Description

Issue 7057 - [CMS] Build failing for `urllib3`

Patch Set 1 #

Created: Oct. 17, 2018, 12:09 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tox.ini	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Tudor Avram

Hi Vasily, Here is the updated `tox.ini`, to avoid further issues with urllib3 (at least ...

Oct. 17, 2018, 12:11 p.m. (2018-10-17 12:11:46 UTC) #1

Vasily Kuznetsov

Oct. 17, 2018, 2:44 p.m. (2018-10-17 14:44:02 UTC) #2

On 2018/10/17 12:11:46, Tudor Avram wrote:
> Hi Vasily, 
> 
> Here is the updated `tox.ini`, to avoid further issues with urllib3 (at least
> until the issue gets fixed). From what I saw in the discussion from
> here(https://github.com/urllib3/urllib3/issues/1456), requests should be
updated
> to support the new build of `urllib3` in a week or so.
> 
> Thanks, 
> Tudor.

LGTM

Expand All Messages | Collapse All Messages