Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29932584: Issue 7003 - Add tests for new filter matching behavior (Closed)

Created:
Nov. 1, 2018, 12:58 a.m. by Manish Jethani
Modified:
Nov. 1, 2018, 6:01 p.m.
Reviewers:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M test/matcher.js View 2 chunks +5 lines, -2 lines 2 comments Download

Messages

Total messages: 3
Manish Jethani
Nov. 1, 2018, 12:58 a.m. (2018-11-01 00:58:15 UTC) #1
Manish Jethani
Patch Set 1 https://codereview.adblockplus.org/29932584/diff/29932585/test/matcher.js File test/matcher.js (right): https://codereview.adblockplus.org/29932584/diff/29932585/test/matcher.js#newcode61 test/matcher.js:61: function checkMatch(test, filters, location, contentType, docDomain, ...
Nov. 1, 2018, 1 a.m. (2018-11-01 01:00:34 UTC) #2
hub
Nov. 1, 2018, 3:02 p.m. (2018-11-01 15:02:14 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld