Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29933555: Noissue - fix coding style and adjust linting config (Closed)

Created:
Nov. 1, 2018, 11:21 a.m. by Vasily Kuznetsov
Modified:
Nov. 1, 2018, 9:10 p.m.
Reviewers:
rhowell
Base URL:
https://hg.adblockplus.org/python-abp
Visibility:
Public.

Description

Noissue - fix coding style and adjust linting config Repository: https://hg.adblockplus.org/python-abp Base revision: c6d7b1341181

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M abp/filters/parser.py View 4 chunks +9 lines, -6 lines 0 comments Download
M abp/filters/sources.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/test_diff_script.py View 1 chunk +1 line, -2 lines 1 comment Download
M tests/test_parser.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/test_renderer.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tox.ini View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Vasily Kuznetsov
Nov. 1, 2018, 11:21 a.m. (2018-11-01 11:21:40 UTC) #1
rhowell
Nov. 1, 2018, 8:50 p.m. (2018-11-01 20:50:15 UTC) #2
Thanks for fixing this up. LGTM, and flake8 succeeds again.  :)

https://codereview.adblockplus.org/29933555/diff/29933556/tests/test_diff_scr...
File tests/test_diff_script.py (right):

https://codereview.adblockplus.org/29933555/diff/29933556/tests/test_diff_scr...
tests/test_diff_script.py:129: latest = re.sub(r'&act=ads_', '! ', BASE) +
'&adurl=\n'
Ah, good catch here.

Powered by Google App Engine
This is Rietveld